Make sure API configuration changes are reflected on the UI #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deshsidd
requested review from
ansjcy,
jainankitk and
dzane17
as code owners
deshsidd
changed the title
deshsidd
changed the title
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
deshsidd
force-pushed
the
sid/api-config-change-bug
branch
from
fd67fb9 to
b3a38ba
Compare
|
I think the issue is actually with not passing in window_size with memory enablement. Error message in console: Which is pointing to https://github.com/opensearch-project/query-insights-dashboards/blob/main/public/pages/TopNQueries/TopNQueries.tsx#L205. If this window_size is not passed, it errors out before setting enabled as true. |
This reverts commit b3a38ba. Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
derek-ho
approved these changes
Nov 12, 2024
deshsidd
changed the title
dzane17
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bug fix where the API configuration changes are not reflected on the UI on page refresh.
If window_size is not passed while enabling a metric_type the error causes the configuration changes to not display on the UI for the specific type.
Fixed by checking for
window_sizebefore trying to parse it. Ifwindow_sizedoes not exist, use the default value1m.Testing
Tested on local by deploying OS with query insights and OSD with query insights dashboards. Verified that updating the settings via API is now reflected when we refresh the UI page.
Issues Resolved
Closes: #27
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.