Bump @babel/traverse from 7.20.13 to 7.23.2 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.20.13 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
reviewed
Oct 19, 2023
test/misc.test.js
Outdated
| @@ -21,7 +21,7 @@ describe('download report errors', () => { | |||
| }, 150000); | |||
|
|
|||
| test('download csv report from custom tenant', async () => { | |||
| let result = await cli(['-u', `${url}/app/discover#/view/571aaf70-4c88-11e8-b3d7-01146121b73d`, '-a', 'basic', '-c', credentials, | |||
| let result = await cli(['-u', `${url}/app/data-explorer/discover#/view/571aaf70-4c88-11e8-b3d7-01146121b73d`, '-a', 'basic', '-c', credentials, | |||
There was a problem hiding this comment.
@joshuali925 not familiar with this tool - this isn't breaking any behavior right? Just saying if I generate report on this URL I am expecting something
There was a problem hiding this comment.
it's test so shouldn't break, but this might need to change to include old and new discover url
reporting-cli/src/download-helpers.js
Line 190 in 861b7ea
derek-ho
approved these changes
Oct 19, 2023
joshuali925
approved these changes
Oct 19, 2023
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
reviewed
Dec 27, 2023
test/errors.test.js
Outdated
Comment on lines
43
to
41
| test('saved search error', async () => { | ||
| let result = await cli(['-u', `${url}/app/discover#/`, '-a', 'basic', '-c', credentials, '-f', 'csv'], '.'); | ||
| expect(result.code).toBe(1); | ||
| expect(result.stderr).toContain('Please save search and retry'); | ||
| }, 150000); | ||
|
|
derek-ho
reviewed
Dec 27, 2023
test/format.test.js
Outdated
| @@ -37,7 +37,7 @@ describe('report format option', () => { | |||
| }, 30000); | |||
|
|
|||
| test('download csv report', async () => { | |||
| let result = await cli(['-u', `${url}/app/discover#/view/3ba638e0-b894-11e8-a6d9-e546fe2bba5f`, '-a', 'basic', '-c', credentials, | |||
| let result = await cli(['-u', `${url}/app/data-explorer/discover/#/view/3ba638e0-b894-11e8-a6d9-e546fe2bba5f`, '-a', 'basic', '-c', credentials, | |||
derek-ho
reviewed
Dec 27, 2023
test/misc.test.js
Outdated
| @@ -21,7 +21,7 @@ describe('download report errors', () => { | |||
| }, 150000); | |||
|
|
|||
| test('download csv report from custom tenant', async () => { | |||
| let result = await cli(['-u', `${url}/app/discover#/view/571aaf70-4c88-11e8-b3d7-01146121b73d`, '-a', 'basic', '-c', credentials, | |||
| let result = await cli(['-u', `${url}/app/data-explorer/discover/#/view/571aaf70-4c88-11e8-b3d7-01146121b73d`, '-a', 'basic', '-c', credentials, | |||
|
@Swiddis @sumukhswamy can you take a look here and close on this? I spent a while on it but can't figure out why it's erroring out on the custom tenant. Custom tenant in other files seems to work fine, but maybe something is different with the new discover. Thanks! |
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
YANG-DB
approved these changes
Mar 21, 2024
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
rupal-bq
approved these changes
Mar 21, 2024
dependabot
bot
deleted the
dependabot/npm_and_yarn/babel/traverse-7.23.2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps @babel/traverse from 7.20.13 to 7.23.2.
Release notes
Sourced from
@babel/traverse's releases.... (truncated)
Changelog
Sourced from
@babel/traverse's changelog.... (truncated)
Commits
b4b9942v7.23.2b13376bOnly evaluate own String/Number/Math methods (#16033)ca58ec1v7.23.00f333daAddcreateImportExpressionsparser option (#15682)3744545Fix lintingc7e6806Addt.buildUndefinedNode(#15893)38ee8b4Expand evaluation of global built-ins in@babel/traverse(#15797)9f3dfd9v7.22.203ed28b2Fully support||and&&inpluginToggleBooleanFlag(#15961)77b0d73v7.22.19You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.