Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snapshot build and upgrade to OpenSearch 1.1. #139

Closed
wants to merge 2 commits into from

Conversation

dblock
Copy link
Member

@dblock dblock commented Aug 17, 2021

Signed-off-by: dblock dblock@amazon.com

Description

Fixes and defaults to snapshot build. Requires OpenSearch 1.1.

Issues Resolved

Closes #138.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

Codecov Report

Merging #139 (9e0848a) into main (b3cf1d4) will increase coverage by 10.87%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##               main     #139       +/-   ##
=============================================
+ Coverage     62.42%   73.30%   +10.87%     
=============================================
  Files           101       32       -69     
  Lines          4484     2030     -2454     
  Branches        681      404      -277     
=============================================
- Hits           2799     1488     -1311     
+ Misses         1517      539      -978     
+ Partials        168        3      -165     
Flag Coverage Δ
dashboards-reports 73.30% <ø> (ø)
reports-scheduler ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tsscheduler/scheduler/ReportDefinitionJobRunner.kt
...h/reportsscheduler/index/ReportDefinitionsIndex.kt
...scheduler/model/GetAllReportDefinitionsResponse.kt
...ortsscheduler/model/GetReportDefinitionResponse.kt
...search/reportsscheduler/model/ReportInstanceDoc.kt
...sscheduler/action/GetAllReportDefinitionsAction.kt
...nsearch/reportsscheduler/metrics/BasicCounter.java
.../reportsscheduler/model/ReportDefinitionDetails.kt
...opensearch/reportsscheduler/model/SearchResults.kt
...search/reportsscheduler/action/PluginBaseAction.kt
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3cf1d4...9e0848a. Read the comment docs.

Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock force-pushed the fix-snapshot-build branch from 9e0848a to d8d9c6e Compare August 17, 2021 16:33
Signed-off-by: dblock <dblock@amazon.com>
Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't remove the job-scheduler zip in test/resources. Even tho the CI can pass since you modify the workflow to build and add the job-scheduler artifact to the test resources, the local build will still fail

@dblock
Copy link
Member Author

dblock commented Aug 18, 2021

Don't want to lose a branch with this code, so replaced this PR with #140.

@dblock dblock closed this Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Snapshot build is broken
3 participants