[Backport 2.x] Enable Detekt #523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
Signed-off-by: Rupal Mahajan <maharup@amazon.com> (cherry picked from commit 5e3047d)
joshuali925
approved these changes
Oct 28, 2022
Codecov Report
@@ Coverage Diff @@
## 2.x #523 +/- ##
============================================
- Coverage 74.32% 74.27% -0.06%
Complexity 383 383
============================================
Files 94 94
Lines 4047 4050 +3
Branches 649 649
============================================
Hits 3008 3008
- Misses 905 908 +3
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ps48
reviewed
Oct 31, 2022
| @@ -40,6 +40,7 @@ buildscript { | |||
| classpath "${opensearch_group}.gradle:build-tools:${opensearch_version}" | |||
| classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:${kotlin_version}" | |||
| classpath "org.jetbrains.kotlin:kotlin-allopen:${kotlin_version}" | |||
| classpath "io.gitlab.arturbosch.detekt:detekt-gradle-plugin:1.22.0-RC2" | |||
There was a problem hiding this comment.
Do we want to add a release candidate library here? @rupal-bq @joshuali925
There was a problem hiding this comment.
Sorry missed this earlier in the original PR.
There was a problem hiding this comment.
Alternatively, we can use Detekt v1.21.0 and force use snakeyaml 1.32.
anirudha
approved these changes
Oct 31, 2022
This was referenced Oct 31, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 5e3047d from #522