[Backport 2.x] Updates demo certs used in integ tests #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
Signed-off-by: Darshit Chanpura <dchanp@amazon.com> (cherry picked from commit 3d17d50) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rupal-bq
approved these changes
Sep 13, 2023
joshuali925
approved these changes
Sep 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
(cherry picked from commit 3d17d50) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 78c8c89) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peterzhuamazon
added a commit
that referenced
this pull request
Oct 31, 2023
* Remove odfe bwc test (#408) (#409) * removed odfe bwc test Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * removed bwc test from workflows Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 556b5fb) Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> * Remove odfe bwc test (#408) * removed odfe bwc test Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * removed bwc test from workflows Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 556b5fb) * Bump version 2.2.0 Signed-off-by: vamsi-amazon <reddyvam@amazon.com> * Bump version 2.2.0 (#413) Signed-off-by: vamsi-amazon <reddyvam@amazon.com> (cherry picked from commit c91534a) Co-authored-by: vamsi-amazon <reddyvam@amazon.com> * Release notes for 2.2.0 Signed-off-by: vamsi-amazon <reddyvam@amazon.com> (cherry picked from commit f43f7de) * Release notes for 2.2.0 Signed-off-by: vamsi-amazon <reddyvam@amazon.com> (cherry picked from commit f43f7de) * [2.x] Restrict chromium requests (#435) * Fix regex validation, detect iframe, embed, object tags Signed-off-by: Joshua Li <joshuali925@gmail.com> * Disallow redirection to non-localhost urls Signed-off-by: Joshua Li <joshuali925@gmail.com> * Disallow connection to non-allowlisted urls Signed-off-by: Joshua Li <joshuali925@gmail.com> * Disable JIT Signed-off-by: Joshua Li <joshuali925@gmail.com> * Fix workflow Signed-off-by: Joshua Li <joshuali925@gmail.com> * Try to fix CI Signed-off-by: Joshua Li <joshuali925@gmail.com> * Fix localstorage logic Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> * [2.2] Restrict chromium requests (#431) * Fix regex validation, detect iframe, embed, object tags Signed-off-by: Joshua Li <joshuali925@gmail.com> * Disallow redirection to non-localhost urls Signed-off-by: Joshua Li <joshuali925@gmail.com> * Disallow connection to non-allowlisted urls Signed-off-by: Joshua Li <joshuali925@gmail.com> * Disable JIT Signed-off-by: Joshua Li <joshuali925@gmail.com> * Fix workflow Signed-off-by: Joshua Li <joshuali925@gmail.com> * Try to fix CI Signed-off-by: Joshua Li <joshuali925@gmail.com> * Fix localstorage logic Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> * Increment version to 2.2.1-SNAPSHOT Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> * Increment version to 2.3.0-SNAPSHOT Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> * Added release notes for 2.2.1 release Signed-off-by: vamsi-amazon <reddyvam@amazon.com> * Merge pull request #459 from mengweieric/release-notes-2.3.0 Release notes for 2.3.0 (cherry picked from commit b0c5643) * [2.x] Upgrade puppeteer (#489) * upgrade puppeteer & change report timeout Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Change timeout Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Bump verison 2.4.0 (#499) Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> * add group = org.opensearch.plugin (#506) (#507) Signed-off-by: prudhvigodithi <pgodithi@amazon.com> Signed-off-by: prudhvigodithi <pgodithi@amazon.com> (cherry picked from commit b25984b) Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com> * feat: enable windows and macos build (#504) (#511) Signed-off-by: Derek Ho <dxho@amazon.com> * Update version for jsdom, terser and jsoup (#515) Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix snakeyaml vulnerability issue by disabling detekt (#517) Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Update ktlint version (#519) Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Upgrade minimatch, moment (#513) Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Revert detekt changes with upgraded version 1.21.0 (#527) Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Add loader-utils to resolutions (#525) Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Nit: add resolutions at once place (#529) (#530) Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> (cherry picked from commit 0dada24) Co-authored-by: Rupal Mahajan <maharup@amazon.com> * add release notes for 2.4.0.0 (#532) (#533) Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> (cherry picked from commit a1c4839) Co-authored-by: Rupal Mahajan <maharup@amazon.com> * Bump loader-utils from 2.0.3 to 2.0.4 in /dashboards-reports (#539) (#541) Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.3 to 2.0.4. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md) - [Commits](webpack/loader-utils@v2.0.3...v2.0.4) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit f250deb) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update qs 6.5.3 (#545) Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix metrics tests and ClassNotFoundException when calling stats API (#546) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Use advanced settings for leading wildcards in query for csv reports (#549) * Fetch allowLeadingWildcards from config Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix tests Signed-off-by: Rupal Mahajan <maharup@amazon.com> * nit Signed-off-by: Rupal Mahajan <maharup@amazon.com> * add default value for allowLeadingWildCards Co-authored-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> * Increment version to 2.5.0-SNAPSHOT (#528) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> * [1.x] Upgrade decode-uri-component (#558) (#560) * upgrade loader-utils for CVE-2022-37601 Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Update async for CVE-2021-43138 Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix cross-fetch for CVE-2022-1365 Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix for CVE-2022-37599, CVE-2022-37603 Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Update terser for CVE-2022-25858 Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Update minimatch for CVE-2022-3517 Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Update moment for CVE-2022-24785 Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Update jsdom for CVE-2021-20066 Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Update execa for GMS-2020-2 Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Update qs for CVE-2022-24999 Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Update moment for CVE-2022-31129 Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Update decode-uri-component for CVE-2022-38900 Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> (cherry picked from commit d3f36b5) Co-authored-by: Rupal Mahajan <maharup@amazon.com> * Fix windows and macos CI (#569) (#571) * Update windows & mac CI for reo name change Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix linux build Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> (cherry picked from commit 9ce8684) Co-authored-by: Rupal Mahajan <maharup@amazon.com> * Add ERR_ADDRESS_INVALID in Troubleshooting (#574) * Add workaround for ERR_ADDRESS_INVALID in doc Signed-off-by: Rupal Mahajan <maharup@amazon.com> * nit Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Add release notes for 2.4.1 (#580) Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Remove jackson-databind and jackson-annotations (#587) * Remove jackson-databind and jackson-annotations dependencies Signed-off-by: Rupal Mahajan <maharup@amazon.com> * resolve dompurify conflicting dependencies Signed-off-by: Rupal Mahajan <maharup@amazon.com> * fix build Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Use front-end report generation instead of chromium (#586) * Increment version to 2.4.1-SNAPSHOT (#540) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> * --wip-- Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add initial implementation of client reporting generation Signed-off-by: Joshua Li <joshuali925@gmail.com> * Fix url with basepath Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update header footer height Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update dialog text to not close dialog Signed-off-by: Joshua Li <joshuali925@gmail.com> * Remove console.log Signed-off-by: Joshua Li <joshuali925@gmail.com> * Remove unused components Signed-off-by: Joshua Li <joshuali925@gmail.com> * Remove chromium references Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add report generation error handling Signed-off-by: Joshua Li <joshuali925@gmail.com> * Minor refactors Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add postinstall patch to support safari for html2canvas Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add dompurify Signed-off-by: Joshua Li <joshuali925@gmail.com> * Fix build error Signed-off-by: Joshua Li <joshuali925@gmail.com> * Remove chromium from CI Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update CI artifact name Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> * Remove front end code (#620) * Remove frontend code Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Move one level up Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Update workflow file Signed-off-by: Rupal Mahajan <maharup@amazon.com> * nit: remove dashboard setup from readme Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Remove unnecessary scripts after repo split (#622) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Include integration tests in windows workflow (#624) Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Add release notes for 2.5.0.0 (#628) * Add release notes for 2.5.0.0 Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix version in release notes Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Increment version to 2.6.0 (#636) Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Updated MAINTAINERS.md to match recommended opensearch-project format. (#619) (#635) Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: dblock <dblock@amazon.com> (cherry picked from commit 8e1cdad) Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> * [Backport 2.x] Add jackson-databind and jackson-annotations (#652) * Add jackson-databind and jackson-annotations (#650) Signed-off-by: Rupal Mahajan <maharup@amazon.com> (cherry picked from commit cc34ae8) * Resolve mockito-core conflict Signed-off-by: Rupal Mahajan <maharup@amazon.com> --------- Signed-off-by: Rupal Mahajan <maharup@amazon.com> Co-authored-by: Rupal Mahajan <maharup@amazon.com> * Add publish to maven workflow (#651) (#655) Signed-off-by: Rupal Mahajan <maharup@amazon.com> (cherry picked from commit 1c7a917) Co-authored-by: Rupal Mahajan <maharup@amazon.com> * fix maven publish workflow (#665) (#666) * fix maven publish workflow Signed-off-by: Derek Ho <dxho@amazon.com> * remove bracket Signed-off-by: Derek Ho <dxho@amazon.com> * fix branch names Signed-off-by: Derek Ho <dxho@amazon.com> * stringify 1.3 Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 354f44a) Co-authored-by: Derek Ho <dxho@amazon.com> * Increment version to 2.7.0-SNAPSHOT (#657) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> * Merge pull request #656 from rupal-bq/release-notes-2.6.0 (#659) Add release notes for 2.6.0 (cherry picked from commit 6c1b03e) Signed-off-by: Derek Ho <dxho@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> * Bump snakeyaml to 2.0 (#674) Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit b792396) * upgrade mockito-core (#678) (#679) Signed-off-by: Rupal Mahajan <maharup@amazon.com> (cherry picked from commit 14ecd44) Co-authored-by: Rupal Mahajan <maharup@amazon.com> * [Backport 2.x] Fix ci failures (#681) * Fix ci failures (#662) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit 07956f7) * Pull Job scheduler from maven instead of jenkins (#663) * use maven Signed-off-by: Derek Ho <dxho@amazon.com> * bwc version to 2.7.0 bump Signed-off-by: Derek Ho <dxho@amazon.com> * hard code zips Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Derek Ho <dxho@amazon.com> * Add release notes for 2.7 (#684) (#686) Signed-off-by: Rupal Mahajan <maharup@amazon.com> (cherry picked from commit 8fafd72) Co-authored-by: Rupal Mahajan <maharup@amazon.com> * Update json version to 20230227 (#692) Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Update Gradle Wrapper to 7.6.1 (#689) (#695) Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit ebbb54d) Co-authored-by: Daniel Widdis <widdis@gmail.com> * Increment version to 2.8.0-SNAPSHOT (#688) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> * Add release notes for 2.8 (#705) (#706) Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit f27cdd4) Co-authored-by: Joshua Li <joshuali925@gmail.com> * Removing guava dependency to fix jarhell (#709) (#710) * removing guava to fix jarhell Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update release notes Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit d7ff8cd) Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> * Increment version to 2.9.0-SNAPSHOT Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> * Add 2.9 release notes (#723) (#724) Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> (cherry picked from commit 79a385b) Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * fix ci Signed-off-by: Derek Ho <dxho@amazon.com> * update kotlin version Signed-off-by: Derek Ho <dxho@amazon.com> * update build.gradle Signed-off-by: Derek Ho <dxho@amazon.com> * ktlint Signed-off-by: Derek Ho <dxho@amazon.com> * version bump Signed-off-by: Derek Ho <dxho@amazon.com> * update workflow Signed-off-by: Derek Ho <dxho@amazon.com> * fix imports in tests Signed-off-by: Derek Ho <dxho@amazon.com> * update import from upstream breaking changes Signed-off-by: Derek Ho <dxho@amazon.com> * Merge pull request #748 from derek-ho/insights fix from upstream import changes (cherry picked from commit c254aad) Signed-off-by: Derek Ho <dxho@amazon.com> * Update PluginBaseAction.kt Remove duplicate import Signed-off-by: Derek Ho <dxho@amazon.com> * Update backport CI, add PR merged condition (#750) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Add 2.10 release notes (#758) (#759) (cherry picked from commit 6a93631) Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Increment version to 2.11.0-SNAPSHOT (#756) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> * Updates demo certs used in integ tests (#755) (#757) (cherry picked from commit 3d17d50) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Increment version to 2.12.0-SNAPSHOT (#871) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> * Upgrade JSON to 20231013 to fix CVE-2023-5072 (#912) (#914) (cherry picked from commit b68990f) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Onboard jenkins prod docker images to github actions (#924) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: vamsi-amazon <reddyvam@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: vamsi-amazon <reddyvam@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Rupal <maharup@amazon.com> Co-authored-by: Derek Ho <derek01778@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> Co-authored-by: Derek Ho <dxho@amazon.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Daniel Widdis <widdis@gmail.com> Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3d17d50 from #755.