Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update artifact name #106

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Update artifact name #106

merged 1 commit into from
Mar 1, 2023

Conversation

sejli
Copy link
Member

@sejli sejli commented Feb 27, 2023 •
edited
Loading

Description

Updating artifact name to follow OpenSearch plugin naming conventions.

Build output:

➜ search-processor (main) ✔ ./gradlew build
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 7.4.2
  OS Info               : Mac OS X 12.6.3 (aarch64)
  JDK Version           : 11 (Eclipse Temurin JDK)
  JAVA_HOME             : /Library/Java/JavaVirtualMachines/jdk-11.0.17+8/Contents/Home
  Random Testing Seed   : 32C4AADD1E0C2BC3
  In FIPS 140 mode      : false
=======================================

> Task :compileJava
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :javadoc
/Users/lnse/opensearch/search-processor/src/main/java/org/opensearch/search/relevance/configuration/ConfigurationUtils.java:30: warning: no @param for resultTransformerMap
  public static List<ResultTransformerConfiguration> getResultTransformersFromIndexConfiguration(Settings settings,
                                                     ^
/Users/lnse/opensearch/search-processor/src/main/java/org/opensearch/search/relevance/configuration/ResultTransformerConfigurationFactory.java:32: warning: no @throws for java.io.IOException
    ResultTransformerConfiguration configure(XContentParser parser) throws IOException;
                                   ^
/Users/lnse/opensearch/search-processor/src/main/java/org/opensearch/search/relevance/configuration/ResultTransformerConfigurationFactory.java:40: warning: no @throws for java.io.IOException
    ResultTransformerConfiguration configure(StreamInput streamInput) throws IOException;
                                   ^
3 warnings

> Task :compileTestJava
Note: /Users/lnse/opensearch/search-processor/src/test/java/org/opensearch/search/relevance/actionfilter/SearchActionFilterTests.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.4.2/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 22s
31 actionable tasks: 28 executed, 3 up-to-date
➜ search-processor (main) ✔ ls build/distributions
opensearch-search-processor-2.5.0.0-javadoc.jar     opensearch-search-processor-2.5.0.0.jar
opensearch-search-processor-2.5.0.0-sources.jar     opensearch-search-processor-2.5.0.0.zip
opensearch-search-processor-2.5.0.0-unspecified.pom search-processor-unspecified.pom

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sejli
changing .zip build name
c8a7bdd 
Signed-off-by: Sean Li <lnse@amazon.com>
@sejli sejli requested a review from a team February 27, 2023 21:48
@noCharger
Copy link
Collaborator

One CI failed

org.opensearch.search.relevance.transformer.kendraintelligentranking.configuration.KendraIntelligentRankingConfigurationTests > testSerializeToXContentRoundtrip FAILED
    ParsingException[Failed to parse value [0] for Transformer order, must be >= 1]
        at __randomizedtesting.SeedInfo.seed([C94C719B5F62ADE:1195B20D26FE1F21]:0)
        at app//org.opensearch.search.relevance.transformer.kendraintelligentranking.configuration.KendraIntelligentRankingConfiguration.parse(KendraIntelligentRankingConfiguration.java:84)
        at app//org.opensearch.search.relevance.transformer.kendraintelligentranking.configuration.KendraIntelligentRankingConfigurationTests.testSerializeToXContentRoundtrip(KendraIntelligentRankingConfigurationTests.java:36)
  1> [2023-02-27T12:50:55,724][INFO ][o.o.s.r.t.k.c.KendraIntelligentRankingConfigurationTests] [testSerializeToXContentRoundtrip] before test
  1> [2023-02-27T12:50:55,740][INFO ][o.o.s.r.t.k.c.KendraIntelligentRankingConfigurationTests] [testSerializeToXContentRoundtrip] after test
  1> [2023-02-27T12:50:55,974][INFO ][o.o.s.r.t.k.c.KendraIntelligentRankingConfigurationTests] [testParseWithNullParserAndContext] before test
  1> [2023-02-27T12:50:55,974][INFO ][o.o.s.r.t.k.c.KendraIntelligentRankingConfigurationTests] [testParseWithNullParserAndContext] after test
  1> [2023-02-27T12:50:56,005][INFO ][o.o.s.r.t.k.c.KendraIntelligentRankingConfigurationTests] [testSerializeToStreamRoundtrip] before test
  1> [2023-02-27T12:50:56,021][INFO ][o.o.s.r.t.k.c.KendraIntelligentRankingConfigurationTests] [testSerializeToStreamRoundtrip] after test
  1> [2023-02-27T12:50:56,021][INFO ][o.o.s.r.t.k.c.KendraIntelligentRankingConfigurationTests] [testReadFromSettings] before test
  1> [2023-02-27T12:50:56,021][INFO ][o.o.s.r.t.k.c.KendraIntelligentRankingConfigurationTests] [testReadFromSettings] after test

Also let's add a sanity test output for the snapshot / zip created

@sejli
Copy link
Member Author

sejli commented Feb 28, 2023

One CI failed

org.opensearch.search.relevance.transformer.kendraintelligentranking.configuration.KendraIntelligentRankingConfigurationTests > testSerializeToXContentRoundtrip FAILED
    ParsingException[Failed to parse value [0] for Transformer order, must be >= 1]
        at __randomizedtesting.SeedInfo.seed([C94C719B5F62ADE:1195B20D26FE1F21]:0)
        at app//org.opensearch.search.relevance.transformer.kendraintelligentranking.configuration.KendraIntelligentRankingConfiguration.parse(KendraIntelligentRankingConfiguration.java:84)
        at app//org.opensearch.search.relevance.transformer.kendraintelligentranking.configuration.KendraIntelligentRankingConfigurationTests.testSerializeToXContentRoundtrip(KendraIntelligentRankingConfigurationTests.java:36)
  1> [2023-02-27T12:50:55,724][INFO ][o.o.s.r.t.k.c.KendraIntelligentRankingConfigurationTests] [testSerializeToXContentRoundtrip] before test
  1> [2023-02-27T12:50:55,740][INFO ][o.o.s.r.t.k.c.KendraIntelligentRankingConfigurationTests] [testSerializeToXContentRoundtrip] after test
  1> [2023-02-27T12:50:55,974][INFO ][o.o.s.r.t.k.c.KendraIntelligentRankingConfigurationTests] [testParseWithNullParserAndContext] before test
  1> [2023-02-27T12:50:55,974][INFO ][o.o.s.r.t.k.c.KendraIntelligentRankingConfigurationTests] [testParseWithNullParserAndContext] after test
  1> [2023-02-27T12:50:56,005][INFO ][o.o.s.r.t.k.c.KendraIntelligentRankingConfigurationTests] [testSerializeToStreamRoundtrip] before test
  1> [2023-02-27T12:50:56,021][INFO ][o.o.s.r.t.k.c.KendraIntelligentRankingConfigurationTests] [testSerializeToStreamRoundtrip] after test
  1> [2023-02-27T12:50:56,021][INFO ][o.o.s.r.t.k.c.KendraIntelligentRankingConfigurationTests] [testReadFromSettings] before test
  1> [2023-02-27T12:50:56,021][INFO ][o.o.s.r.t.k.c.KendraIntelligentRankingConfigurationTests] [testReadFromSettings] after test

Also let's add a sanity test output for the snapshot / zip created

Think it's a flaky test. Reran with the specific random seed on my branch and the current the current main branch and they both failed. Other runs pass successfully.

search-processor (82e59f1) ✔ ./gradlew ':test' --tests "org.opensearch.search.relevance.transformer.kendraintelligentranking.configuration.KendraIntelligentRankingConfigurationTests.testSerializeToXContentRoundtrip" -Dtests.seed=C94C719B5F62ADE -Dtests.security.manager=true -Dtests.locale=vi-VN -Dtests.timezone=Etc/GMT+9                
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 7.4.2
  OS Info               : Mac OS X 12.6.3 (aarch64)
  JDK Version           : 11 (Eclipse Temurin JDK)
  JAVA_HOME             : /Library/Java/JavaVirtualMachines/jdk-11.0.17+8/Contents/Home
  Random Testing Seed   : C94C719B5F62ADE
  In FIPS 140 mode      : false
=======================================

> Task :test FAILED


org.opensearch.search.relevance.transformer.kendraintelligentranking.configuration.KendraIntelligentRankingConfigurationTests > testSerializeToXContentRoundtrip FAILED
    ParsingException[Failed to parse value [0] for Transformer order, must be >= 1]
        at __randomizedtesting.SeedInfo.seed([C94C719B5F62ADE:1195B20D26FE1F21]:0)
        at app//org.opensearch.search.relevance.transformer.kendraintelligentranking.configuration.KendraIntelligentRankingConfiguration.parse(KendraIntelligentRankingConfiguration.java:84)
        at app//org.opensearch.search.relevance.transformer.kendraintelligentranking.configuration.KendraIntelligentRankingConfigurationTests.testSerializeToXContentRoundtrip(KendraIntelligentRankingConfigurationTests.java:36)
REPRODUCE WITH: ./gradlew ':test' --tests "org.opensearch.search.relevance.transformer.kendraintelligentranking.configuration.KendraIntelligentRankingConfigurationTests.testSerializeToXContentRoundtrip" -Dtests.seed=C94C719B5F62ADE -Dtests.security.manager=true -Dtests.locale=vi-VN -Dtests.timezone=Etc/GMT+9 -Druntime.java=11

Suite: Test class org.opensearch.search.relevance.transformer.kendraintelligentranking.configuration.KendraIntelligentRankingConfigurationTests
  1> [2023-02-27T17:08:19,270][WARN ][o.o.b.Natives            ] [[SUITE-KendraIntelligentRankingConfigurationTests-seed#[C94C719B5F62ADE]]] unable to load JNA native support library, native methods will be disabled.
  1> java.lang.UnsatisfiedLinkError: Can't load library: /Users/lnse/Library/Caches/JNA/temp/jna10477499904397165298.tmp
  1>    at java.lang.ClassLoader.loadLibrary(ClassLoader.java:2633) ~[?:?]
  1>    at java.lang.Runtime.load0(Runtime.java:768) ~[?:?]
  1>    at java.lang.System.load(System.java:1837) ~[?:?]
  1>    at com.sun.jna.Native.loadNativeDispatchLibraryFromClasspath(Native.java:1018) ~[jna-5.5.0.jar:5.5.0 (b0)]
  1>    at com.sun.jna.Native.loadNativeDispatchLibrary(Native.java:988) ~[jna-5.5.0.jar:5.5.0 (b0)]
  1>    at com.sun.jna.Native.<clinit>(Native.java:195) ~[jna-5.5.0.jar:5.5.0 (b0)]
  1>    at java.lang.Class.forName0(Native Method) ~[?:?]
  1>    at java.lang.Class.forName(Class.java:315) ~[?:?]
  1>    at org.opensearch.bootstrap.Natives.<clinit>(Natives.java:60) [opensearch-2.5.0.jar:2.5.0]
  1>    at org.opensearch.bootstrap.Bootstrap.initializeNatives(Bootstrap.java:123) [opensearch-2.5.0.jar:2.5.0]
  1>    at org.opensearch.bootstrap.BootstrapForTesting.<clinit>(BootstrapForTesting.java:105) [framework-2.5.0.jar:2.5.0]
  1>    at org.opensearch.test.OpenSearchTestCase.<clinit>(OpenSearchTestCase.java:257) [framework-2.5.0.jar:2.5.0]
  1>    at java.lang.Class.forName0(Native Method) ~[?:?]
  1>    at java.lang.Class.forName(Class.java:398) [?:?]
  1>    at com.carrotsearch.randomizedtesting.RandomizedRunner$2.run(RandomizedRunner.java:623) [randomizedtesting-runner-2.7.1.jar:?]
  1> [2023-02-27T17:08:19,285][WARN ][o.o.b.Natives            ] [[SUITE-KendraIntelligentRankingConfigurationTests-seed#[C94C719B5F62ADE]]] cannot check if running as root because JNA is not available
  1> [2023-02-27T17:08:19,285][WARN ][o.o.b.Natives            ] [[SUITE-KendraIntelligentRankingConfigurationTests-seed#[C94C719B5F62ADE]]] cannot install system call filter because JNA is not available
  1> [2023-02-27T17:08:19,286][WARN ][o.o.b.Natives            ] [[SUITE-KendraIntelligentRankingConfigurationTests-seed#[C94C719B5F62ADE]]] cannot register console handler because JNA is not available
  1> [2023-02-27T17:08:19,287][WARN ][o.o.b.Natives            ] [[SUITE-KendraIntelligentRankingConfigurationTests-seed#[C94C719B5F62ADE]]] cannot getrlimit RLIMIT_NPROC because JNA is not available
  1> [2023-02-27T17:08:19,287][WARN ][o.o.b.Natives            ] [[SUITE-KendraIntelligentRankingConfigurationTests-seed#[C94C719B5F62ADE]]] cannot getrlimit RLIMIT_AS because JNA is not available
  1> [2023-02-27T17:08:19,287][WARN ][o.o.b.Natives            ] [[SUITE-KendraIntelligentRankingConfigurationTests-seed#[C94C719B5F62ADE]]] cannot getrlimit RLIMIT_FSIZE because JNA is not available
  1> [2023-02-27T16:08:19,665][INFO ][o.o.s.r.t.k.c.KendraIntelligentRankingConfigurationTests] [testSerializeToXContentRoundtrip] before test
  1> [2023-02-27T16:08:19,868][INFO ][o.o.s.r.t.k.c.KendraIntelligentRankingConfigurationTests] [testSerializeToXContentRoundtrip] after test
  2> REPRODUCE WITH: ./gradlew ':test' --tests "org.opensearch.search.relevance.transformer.kendraintelligentranking.configuration.KendraIntelligentRankingConfigurationTests.testSerializeToXContentRoundtrip" -Dtests.seed=C94C719B5F62ADE -Dtests.security.manager=true -Dtests.locale=vi-VN -Dtests.timezone=Etc/GMT+9 -Druntime.java=11
  2> ParsingException[Failed to parse value [0] for Transformer order, must be >= 1]
        at __randomizedtesting.SeedInfo.seed([C94C719B5F62ADE:1195B20D26FE1F21]:0)
        at app//org.opensearch.search.relevance.transformer.kendraintelligentranking.configuration.KendraIntelligentRankingConfiguration.parse(KendraIntelligentRankingConfiguration.java:84)
        at app//org.opensearch.search.relevance.transformer.kendraintelligentranking.configuration.KendraIntelligentRankingConfigurationTests.testSerializeToXContentRoundtrip(KendraIntelligentRankingConfigurationTests.java:36)
  2> NOTE: leaving temporary files on disk at: /Users/lnse/opensearch/search-processor/build/testrun/test/temp/org.opensearch.search.relevance.transformer.kendraintelligentranking.configuration.KendraIntelligentRankingConfigurationTests_C94C719B5F62ADE-002
  2> NOTE: test params are: codec=Asserting(Lucene94): {}, docValues:{}, maxPointsInLeafNode=1933, maxMBSortInHeap=6.854586443954316, sim=Asserting(RandomSimilarity(queryNorm=true): {}), locale=vi-VN, timezone=Etc/GMT+9
  2> NOTE: Mac OS X 12.6.3 aarch64/Eclipse Adoptium 11.0.17 (64-bit)/cpus=10,threads=1,free=405602816,total=536870912
  2> NOTE: All tests run in this JVM: [KendraIntelligentRankingConfigurationTests]

Tests with failures:
 - org.opensearch.search.relevance.transformer.kendraintelligentranking.configuration.KendraIntelligentRankingConfigurationTests.testSerializeToXContentRoundtrip

1 test completed, 1 failed

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: file:///Users/lnse/opensearch/search-processor/build/reports/tests/test/index.html

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.4.2/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 2s
7 actionable tasks: 2 executed, 5 up-to-date

noCharger
noCharger approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's create another issue to track flaky test.

@sejli sejli mentioned this pull request Feb 28, 2023
Closed
@msfroh msfroh merged commit fa082b0 into opensearch-project:main Mar 1, 2023
@sejli sejli added the backport 2.x Backport to 2.x branch label Mar 1, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 1, 2023
@sejli @github-actions
changing .zip build name (#106)
06b756f 
(cherry picked from commit fa082b0)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 1, 2023
Merged
noCharger pushed a commit that referenced this pull request Mar 1, 2023
@opensearch-trigger-bot @sejli
changing .zip build name (#106) (#109)
c59d8cd 
(cherry picked from commit fa082b0)

Co-authored-by: Sean Li <lnse@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noCharger noCharger noCharger approved these changes

@msfroh msfroh msfroh approved these changes

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sejli @noCharger @msfroh