Bug fix: Fix NPE when parsing field names in query parser. #23
Conversation
| private static final String QUERY_PARSER_RESULT_LOG = | ||
| "Kendra Intelligent Ranker query parser result for query type [%s]: queryText: %s, bodyField: %s, titleField: %s"; | ||
| private static final String QUERY_PARSER_RESULT_LOG_WITHOUT_TITLE = | ||
| "Kendra Intelligent Ranker query parser result for query type [%s]: queryText: %s, bodyField: %s"; |
There was a problem hiding this comment.
Do we want to enable logging for all queries sent to Kendra?
My big concern with that is a) the increase in the volume of stuff that we're logging and b) the risk of logging user queries without conscious action on the part of the admin.
There was a problem hiding this comment.
Good point, especially with (b)
How about making this a debug log and removing the query text, but keeping body and title field names? It's difficult to debug which fields got sent to Kendra, especially since the title is optional.
There was a problem hiding this comment.
I think I'm okay with keeping it at INFO level, as long as we remove the query text.
The query text logging specifically is the part that I'm a little nervous about.
* Update gitignore for Intellij Signed-off-by: Mahita Mahesh <mahitam@amazon.com>
mahitamahesh
force-pushed
the
bug-fix
branch
from
fd138d0 to
63582d8
Compare
* Update gitignore for Intellij Signed-off-by: Mahita Mahesh <mahitam@amazon.com> Signed-off-by: Mahita Mahesh <mahitam@amazon.com> Co-authored-by: Mahita Mahesh <mahitam@amazon.com>
Description
Bug fix: Fix NPE when parsing field names in query parser.
Issues Resolved
No existing issue
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.