Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor updates to README.md; removed dead link to credits and an unnec… #65

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

macohen
Copy link
Collaborator

@macohen macohen commented Dec 23, 2022

…essary period

Signed-off-by: Mark Cohen markcoh@amazon.com

Description

Makes the README a little nicer and triggers pr_stats against main.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…essary period

Signed-off-by: Mark Cohen <markcoh@amazon.com>
@macohen macohen requested a review from a team December 23, 2022 16:33
@codecov-commenter
Copy link

Codecov Report

Merging #65 (86a60d4) into main (579f205) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #65   +/-   ##
=========================================
  Coverage     65.52%   65.52%           
  Complexity      172      172           
=========================================
  Files            29       29           
  Lines           879      879           
  Branches        119      119           
=========================================
  Hits            576      576           
  Misses          254      254           
  Partials         49       49           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@macohen macohen marked this pull request as draft December 23, 2022 16:53
@macohen macohen marked this pull request as ready for review December 23, 2022 16:53
Copy link
Collaborator

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@noCharger noCharger merged commit d654ad6 into opensearch-project:main Dec 23, 2022
@noCharger noCharger added the backport 2.x Backport to 2.x branch label Dec 23, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 23, 2022
…essary period (#65)

Signed-off-by: Mark Cohen <markcoh@amazon.com>

Signed-off-by: Mark Cohen <markcoh@amazon.com>
(cherry picked from commit d654ad6)
noCharger pushed a commit that referenced this pull request Jan 4, 2023
…ts and an unnecessary period (#65) (#68)

Signed-off-by: Mark Cohen <markcoh@amazon.com>

Signed-off-by: Mark Cohen <markcoh@amazon.com>
(cherry picked from commit d654ad6)

Co-authored-by: Mark Cohen <markcoh@amazon.com>
@mingshl mingshl added the documentation Improvements or additions to documentation label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants