adding Mingshi Liu as a maintainer to the repo #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Cohen <markcoh@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #86 +/- ##
=========================================
Coverage 65.52% 65.52%
Complexity 172 172
=========================================
Files 29 29
Lines 879 879
Branches 119 119
=========================================
Hits 576 576
Misses 254 254
Partials 49 49 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
msfroh
approved these changes
Jan 23, 2023
mingshl
added
documentation
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-86-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 60f6cbbb28c9da412225b1234066ad28fe7d2e29
# Push it to GitHub
git push --set-upstream origin backport/backport-86-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
mingshl
added a commit
to mingshl/search-processor
that referenced
this pull request
Jan 23, 2023
adding Mingshi Liu as a maintainer to the repo (cherry picked from commit 60f6cbb)
This was referenced Jan 23, 2023
mingshl
added a commit
to mingshl/search-processor
that referenced
this pull request
Jan 23, 2023
adding Mingshi Liu as a maintainer to the repo (cherry picked from commit 60f6cbb) Signed-off-by: Mingshi Liu <mingshl@amazon.com>
msfroh
pushed a commit
that referenced
this pull request
Jan 24, 2023
adding Mingshi Liu as a maintainer to the repo (cherry picked from commit 60f6cbb) Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mark Cohen markcoh@amazon.com
Description
adds mingshl@ as a maintainer
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.