Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ux improvements for correlations page #732

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

amsiglan
Copy link
Collaborator

Description

Makes improvements for the correlations graph and related UI

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #732 (657f4d7) into main (b8b3298) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
- Coverage   31.49%   31.48%   -0.01%     
==========================================
  Files         150      150              
  Lines        4814     4818       +4     
  Branches      803      803              
==========================================
+ Hits         1516     1517       +1     
- Misses       3119     3122       +3     
  Partials      179      179              

see 2 files with indirect coverage changes

@amsiglan amsiglan merged commit 87bcabb into opensearch-project:main Oct 3, 2023
10 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 3, 2023
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit 87bcabb)
amsiglan added a commit that referenced this pull request Oct 4, 2023
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit 87bcabb)

Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
@amsiglan amsiglan added the backport 2.11 PRs to be backported to 2.11 branch label Oct 4, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.11 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.11 2.11
# Navigate to the new working tree
cd .worktrees/backport-2.11
# Create a new branch
git switch --create backport/backport-732-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 87bcabb4b852f0cbc85117d96b05bce8e453f512
# Push it to GitHub
git push --set-upstream origin backport/backport-732-to-2.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.11

Then, create a pull request where the base branch is 2.11 and the compare/head branch is backport/backport-732-to-2.11.

@amsiglan amsiglan removed the backport 2.11 PRs to be backported to 2.11 branch label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants