-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omit field from mapping payload if it matches index field; Abort detector creation when mapping has failed #752
Merged
amsiglan
merged 1 commit into
opensearch-project:main
from
amsiglan:omit-rule-field-matching-index-name-in-create-mapping
Oct 25, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fails Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
October 11, 2023 02:53
Codecov Report
@@ Coverage Diff @@
## main #752 +/- ##
==========================================
- Coverage 31.28% 31.28% -0.01%
==========================================
Files 150 150
Lines 4913 4920 +7
Branches 880 882 +2
==========================================
+ Hits 1537 1539 +2
- Misses 3192 3197 +5
Partials 184 184 |
AWSHurneyt
approved these changes
Oct 25, 2023
eirsep
approved these changes
Oct 25, 2023
70 tasks
amsiglan
added a commit
that referenced
this pull request
Nov 21, 2023
…eld; Abort detector creation when mapping has failed (#767) * updated field mappings service; abort detector creation when mapping fails (#752) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 1419650) * updated workflow file Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we have updated two behaviors:
view mappings
API. However, a field cannot be mapped backed to itself in an index i.e. an alias name cannot be same as the index field name, so as part of create mapping API payload we should omit the automatically mapped field that matched an index field.create mapping
fails when user hits Create Detector, then we should abort the creation altogether. This behavior was regressed in an earlier version. This PR fixes that.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.