Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete composite monitor during detector deletion #225

Closed
Tracked by #219
eirsep opened this issue Jan 4, 2023 · 2 comments
Closed
Tracked by #219

Delete composite monitor during detector deletion #225

eirsep opened this issue Jan 4, 2023 · 2 comments
Assignees
@stevanbz
Labels
enhancement New feature or request

Comments

@eirsep
Copy link
Member

eirsep commented Jan 4, 2023

When detector is deleted, bucket/doc level monitors and the composite monitor need to deleted as part of resource clean up.

Delete detector flow would involve the following interactions with alerting (ORDER MATTERS):
i. Delete the composite monitor first.
ii. Delete the doc/bucket level monitors
iii. if step i or step ii fail, mark delete detector request as failed.
@eirsep eirsep added enhancement New feature or request untriaged labels Jan 4, 2023
@eirsep eirsep mentioned this issue Jan 4, 2023
Closed
4 tasks
@stevanbz
Copy link
Contributor

stevanbz commented Feb 6, 2023

Followed the steps from the above. The PR that is created for parent issue containing all the changes:
#316

@stevanbz stevanbz mentioned this issue Feb 6, 2023
Open
5 tasks
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this issue Feb 20, 2024
@jovancvetkovic3006
[FEATURE] Add chart tooltips (opensearch-project#225)
091a833 
* [FEATURE] Add chart tooltips opensearch-project#198

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Add chart tooltips opensearch-project#198

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Add interactive legend into charts opensearch-project#199

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Reverting, pushed to wrong branch

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
@engechas
Copy link
Collaborator

This functionality is implemented. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevanbz stevanbz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eirsep @getsaurabh02 @stevanbz @engechas