Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed GetFindings not searching all indices; fixed proper deletion of… #122

Merged
merged 10 commits into from
Nov 9, 2022

Conversation

petardz
Copy link
Contributor

@petardz petardz commented Nov 7, 2022

… old history indices

Signed-off-by: Petar Dzepina petar.dzepina@gmail.com

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… old history indices

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz petardz requested a review from a team November 7, 2022 22:53
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Merging #122 (a044fd4) into main (ee7f6fb) will decrease coverage by 0.88%.
The diff coverage is 22.22%.

@@             Coverage Diff              @@
##               main     #122      +/-   ##
============================================
- Coverage     40.16%   39.28%   -0.89%     
- Complexity      884      890       +6     
============================================
  Files           175      176       +1     
  Lines          6433     6684     +251     
  Branches        785      811      +26     
============================================
+ Hits           2584     2626      +42     
- Misses         3612     3816     +204     
- Partials        237      242       +5     
Impacted Files Coverage Δ
...indexmanagment/DetectorIndexManagementService.java 0.00% <0.00%> (ø)
...alytics/config/monitors/DetectorMonitorConfig.java 53.84% <35.29%> (-1.71%) ⬇️
...search/securityanalytics/alerts/AlertsService.java 21.90% <50.00%> (ø)
...ch/securityanalytics/findings/FindingsService.java 39.70% <50.00%> (ø)
...ecurityanalytics/rules/backend/OSQueryBackend.java 66.37% <0.00%> (-8.91%) ⬇️
...g/opensearch/securityanalytics/model/Detector.java 70.24% <0.00%> (-0.63%) ⬇️
...a/org/opensearch/securityanalytics/model/Rule.java 0.00% <0.00%> (ø)
.../securityanalytics/rules/backend/QueryBackend.java 65.48% <0.00%> (ø)
...yanalytics/transport/TransportIndexRuleAction.java 0.00% <0.00%> (ø)
...lytics/transport/TransportIndexDetectorAction.java 0.00% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@eirsep eirsep merged commit 8dd1c9f into opensearch-project:main Nov 9, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 9, 2022
#122)

* fixed GetFindings not searching all indices; fixed proper deletion of old history indices

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 8dd1c9f)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 9, 2022
#122)

* fixed GetFindings not searching all indices; fixed proper deletion of old history indices

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 8dd1c9f)
eirsep pushed a commit that referenced this pull request Nov 9, 2022
#122) (#136)

* fixed GetFindings not searching all indices; fixed proper deletion of old history indices

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 8dd1c9f)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
eirsep pushed a commit that referenced this pull request Nov 9, 2022
#122) (#135)

* fixed GetFindings not searching all indices; fixed proper deletion of old history indices

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 8dd1c9f)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants