Enabled creation detector without rules #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevanbz
force-pushed
the
bugfix/allow-empty-detector-creation
branch
from
44edb6e to
a09dda4
Compare
Codecov Report
@@ Coverage Diff @@
## main #143 +/- ##
============================================
- Coverage 39.20% 39.12% -0.09%
+ Complexity 891 887 -4
============================================
Files 176 176
Lines 6701 6702 +1
Branches 815 815
============================================
- Hits 2627 2622 -5
- Misses 3833 3837 +4
- Partials 241 243 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com>
stevanbz
force-pushed
the
bugfix/allow-empty-detector-creation
branch
from
a09dda4 to
00ff567
Compare
sbcd90
approved these changes
Nov 10, 2022
eirsep
approved these changes
Nov 10, 2022
eirsep
approved these changes
Nov 10, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 10, 2022
Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com> Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com> Co-authored-by: Stevan Buzejic <stevan.buzejic@htecgroup.com> (cherry picked from commit 68231e9)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 10, 2022
Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com> Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com> Co-authored-by: Stevan Buzejic <stevan.buzejic@htecgroup.com> (cherry picked from commit 68231e9)
getsaurabh02
pushed a commit
that referenced
this pull request
Nov 10, 2022
Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com> Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com> Co-authored-by: Stevan Buzejic <stevan.buzejic@htecgroup.com> (cherry picked from commit 68231e9) Co-authored-by: Stevan Buzejic <30922513+stevanbz@users.noreply.github.com>
getsaurabh02
pushed a commit
that referenced
this pull request
Nov 10, 2022
Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com> Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com> Co-authored-by: Stevan Buzejic <stevan.buzejic@htecgroup.com> (cherry picked from commit 68231e9) Co-authored-by: Stevan Buzejic <30922513+stevanbz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stevan Buzejic stevan.buzejic@htecgroup.com
Description
Enabled empty detector (detector without rules) creation.
Added response handling on detector create request when the list of rules is empty.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.