Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update others_web mappings #304

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

phaseshiftg
Copy link
Contributor

Description

update others_web mappings

Issues Resolved

update others_web mappings

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Grant Haywood <grant@phaseshift.studio>
@phaseshiftg phaseshiftg requested a review from a team January 12, 2023 08:35
sbcd90
sbcd90 previously approved these changes Feb 21, 2023
getsaurabh02
getsaurabh02 previously approved these changes Feb 21, 2023
},
"timestamp": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is timestamp field removed?

@sbcd90 sbcd90 dismissed stale reviews from getsaurabh02 and themself via 2dfe8e8 February 21, 2023 02:25
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023

Codecov Report

Merging #304 (3142ddd) into main (4c160e2) will decrease coverage by 0.36%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #304      +/-   ##
============================================
- Coverage     36.89%   36.53%   -0.36%     
  Complexity      887      887              
============================================
  Files           179      185       +6     
  Lines          7029     7098      +69     
  Branches        857      860       +3     
============================================
  Hits           2593     2593              
- Misses         4199     4268      +69     
  Partials        237      237              
Impacted Files Coverage Δ
.../securityanalytics/rules/backend/QueryBackend.java 64.34% <0.00%> (-1.14%) ⬇️
...opensearch/securityanalytics/util/RuleIndices.java 0.00% <0.00%> (ø)
...rch/securityanalytics/SecurityAnalyticsPlugin.java 0.00% <0.00%> (ø)
...transport/TransportGetAllRuleCategoriesAction.java 0.00% <0.00%> (ø)
...yanalytics/action/GetAllRuleCategoriesRequest.java 0.00% <0.00%> (ø)
...tyanalytics/action/GetAllRuleCategoriesAction.java 0.00% <0.00%> (ø)
...cs/resthandler/RestGetAllRuleCategoriesAction.java 0.00% <0.00%> (ø)
...analytics/action/GetAllRuleCategoriesResponse.java 0.00% <0.00%> (ø)
...ensearch/securityanalytics/model/RuleCategory.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbcd90 sbcd90 merged commit f72911a into opensearch-project:main Feb 21, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 21, 2023
Signed-off-by: Grant Haywood <grant@phaseshift.studio>
(cherry picked from commit f72911a)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 21, 2023
Signed-off-by: Grant Haywood <grant@phaseshift.studio>
(cherry picked from commit f72911a)
sbcd90 pushed a commit that referenced this pull request Feb 21, 2023
Signed-off-by: Grant Haywood <grant@phaseshift.studio>
sbcd90 pushed a commit that referenced this pull request Feb 21, 2023
Signed-off-by: Grant Haywood <grant@phaseshift.studio>
eirsep pushed a commit to eirsep/security-analytics that referenced this pull request Apr 3, 2023
Signed-off-by: Grant Haywood <grant@phaseshift.studio>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants