Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetAllRuleCategories API #327

Merged
merged 7 commits into from
Feb 21, 2023
Merged

Conversation

petardz
Copy link
Contributor

@petardz petardz commented Feb 16, 2023

Description

API to fetch all available log types/rule categories

Issues Resolved

#328

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@petardz petardz requested a review from a team February 16, 2023 18:43
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #327 (47441d7) into main (0f92eee) will decrease coverage by 0.36%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #327      +/-   ##
============================================
- Coverage     36.89%   36.53%   -0.36%     
+ Complexity      887      886       -1     
============================================
  Files           179      185       +6     
  Lines          7029     7095      +66     
  Branches        857      860       +3     
============================================
- Hits           2593     2592       -1     
- Misses         4199     4265      +66     
- Partials        237      238       +1     
Impacted Files Coverage Δ
...rch/securityanalytics/SecurityAnalyticsPlugin.java 0.00% <ø> (ø)
...tyanalytics/action/GetAllRuleCategoriesAction.java 0.00% <0.00%> (ø)
...yanalytics/action/GetAllRuleCategoriesRequest.java 0.00% <0.00%> (ø)
...analytics/action/GetAllRuleCategoriesResponse.java 0.00% <0.00%> (ø)
...ensearch/securityanalytics/model/RuleCategory.java 0.00% <0.00%> (ø)
...cs/resthandler/RestGetAllRuleCategoriesAction.java 0.00% <0.00%> (ø)
...transport/TransportGetAllRuleCategoriesAction.java 0.00% <0.00%> (ø)
...g/opensearch/securityanalytics/model/Detector.java 70.24% <0.00%> (-0.35%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@getsaurabh02 getsaurabh02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,36 @@
{
"rule_categories": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we started using this in the frontend yet? If not lets create an issue on frontend to adopt this.
cc : @amsiglan

@sbcd90 sbcd90 merged commit 3d2d31f into opensearch-project:main Feb 21, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 21, 2023
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 3d2d31f)
sbcd90 pushed a commit that referenced this pull request Feb 21, 2023
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
petardz added a commit to petardz/security-analytics that referenced this pull request Feb 22, 2023
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
eirsep pushed a commit to eirsep/security-analytics that referenced this pull request Apr 3, 2023
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants