Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New log types #332

Merged
merged 21 commits into from
Feb 22, 2023
Merged

New log types #332

merged 21 commits into from
Feb 22, 2023

Conversation

petardz
Copy link
Contributor

@petardz petardz commented Feb 17, 2023

Description

Adding new log types/sigma rules

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@petardz petardz requested a review from a team February 17, 2023 01:27
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2023

Codecov Report

Merging #332 (2f3ec68) into main (0f92eee) will increase coverage by 0.03%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #332      +/-   ##
============================================
+ Coverage     36.89%   36.92%   +0.03%     
  Complexity      887      887              
============================================
  Files           179      179              
  Lines          7029     7033       +4     
  Branches        857      857              
============================================
+ Hits           2593     2597       +4     
  Misses         4199     4199              
  Partials        237      237              
Impacted Files Coverage Δ
...g/opensearch/securityanalytics/model/Detector.java 70.98% <100.00%> (+0.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
…me; replaced v1 template with v2 template for query index template

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
…dded filtering aliases if field already exists in index

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
…ting field in createMappingsAPI; fixed ldap mappings

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@sbcd90 sbcd90 merged commit 2647ef9 into opensearch-project:main Feb 22, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-332-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2647ef9334c14883d259b4215b6251e6523b13db
# Push it to GitHub
git push --set-upstream origin backport/backport-332-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-332-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.6 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.6 2.6
# Navigate to the new working tree
cd .worktrees/backport-2.6
# Create a new branch
git switch --create backport/backport-332-to-2.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2647ef9334c14883d259b4215b6251e6523b13db
# Push it to GitHub
git push --set-upstream origin backport/backport-332-to-2.6
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.6

Then, create a pull request where the base branch is 2.6 and the compare/head branch is backport/backport-332-to-2.6.

sbcd90 added a commit to sbcd90/security-analytics that referenced this pull request Feb 22, 2023
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Co-authored-by: Subhobrata Dey <sbcd90@gmail.com>
sbcd90 added a commit to sbcd90/security-analytics that referenced this pull request Feb 22, 2023
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Co-authored-by: Subhobrata Dey <sbcd90@gmail.com>
sbcd90 added a commit that referenced this pull request Feb 22, 2023
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
sbcd90 added a commit that referenced this pull request Feb 22, 2023
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
eirsep pushed a commit to eirsep/security-analytics that referenced this pull request Apr 3, 2023
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Co-authored-by: Subhobrata Dey <sbcd90@gmail.com>
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Data source in Create detector page should be a single select opensearch-project#332

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants