add mitre attack based auto-correlations support in correlation engine #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
sbcd90
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni and
eirsep
as code owners
|
plz add more elaborate description |
eirsep
reviewed
Sep 6, 2023
| @@ -0,0 +1,9625 @@ | |||
| { | |||
There was a problem hiding this comment.
we generated this from https://github.com/mitre/cti
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
praveensameneni
approved these changes
Sep 6, 2023
Codecov Report
@@ Coverage Diff @@
## main #532 +/- ##
============================================
- Coverage 25.72% 25.47% -0.26%
- Complexity 938 942 +4
============================================
Files 252 253 +1
Lines 10768 10895 +127
Branches 1197 1223 +26
============================================
+ Hits 2770 2775 +5
- Misses 7749 7873 +124
+ Partials 249 247 -2
|
eirsep
reviewed
Sep 6, 2023
| try { | ||
| generateAutoCorrelations(detector, finding); | ||
| } catch (IOException ex) { | ||
| correlateFindingAction.onFailures(ex); |
There was a problem hiding this comment.
can we log error message that auto correlation has failed
eirsep
reviewed
Sep 6, 2023
| int idx = 0; | ||
| for (MultiSearchResponse.Item response : responses) { | ||
| if (response.isFailure()) { | ||
| log.info(response.getFailureMessage()); |
There was a problem hiding this comment.
why info log? error or debug would be better. along with description message of what this failure is from?
eirsep
approved these changes
Sep 6, 2023
|
updated to a more verbose description. added review comments to issue #502 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Findings in security-analytics link sigma rules to logs. Each sigma rule is linked to one or more mitre tactics & techniques. this info along with mitre cti relationships are used to generate auto-correlations among findings.
this pr add mitre attack based auto-correlations support in correlation engine. https://github.com/mitre/cti
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.