Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using alerting workflows in detectors #541

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

sbcd90
Copy link
Collaborator

@sbcd90 sbcd90 commented Sep 6, 2023

Description

backport #533

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #541 (a82fbc9) into 2.x (bf2b219) will decrease coverage by 0.33%.
The diff coverage is 2.43%.

@@             Coverage Diff              @@
##                2.x     #541      +/-   ##
============================================
- Coverage     25.48%   25.15%   -0.33%     
- Complexity      940      941       +1     
============================================
  Files           253      255       +2     
  Lines         10897    11062     +165     
  Branches       1223     1231       +8     
============================================
+ Hits           2777     2783       +6     
- Misses         7873     8028     +155     
- Partials        247      251       +4     
Files Changed Coverage Δ
...rch/securityanalytics/SecurityAnalyticsPlugin.java 2.43% <ø> (ø)
...ytics/transport/TransportDeleteDetectorAction.java 0.00% <0.00%> (ø)
...nalytics/transport/TransportGetFindingsAction.java 0.00% <ø> (ø)
...lytics/transport/TransportIndexDetectorAction.java 0.00% <0.00%> (ø)
...nsearch/securityanalytics/util/MonitorService.java 0.00% <0.00%> (ø)
...search/securityanalytics/util/WorkflowService.java 0.00% <0.00%> (ø)
...g/opensearch/securityanalytics/model/Detector.java 65.73% <35.00%> (-2.55%) ⬇️
...yanalytics/settings/SecurityAnalyticsSettings.java 96.00% <100.00%> (+0.16%) ⬆️

@sbcd90 sbcd90 merged commit 69f9436 into opensearch-project:2.x Sep 6, 2023
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants