Adding WAF Log type #617
Merged
Adding WAF Log type #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #617 +/- ##
============================================
+ Coverage 25.02% 25.06% +0.04%
- Complexity 943 947 +4
============================================
Files 255 255
Lines 11155 11155
Branches 1250 1250
============================================
+ Hits 2791 2796 +5
+ Misses 8110 8107 -3
+ Partials 254 252 -2 |
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
sandeshkr419
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
sbcd90
previously approved these changes
Oct 4, 2023
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
sbcd90
approved these changes
Oct 4, 2023
|
LGTM but plz add tests for end-to-end flow i.e create waf log type detector, ingest docs and assert findings, alerts etc. |
@eirsep Thanks for reviewing. In the following test added, I did create a detector and verified (asserted) percolate queries (via number of rules to be matched) generated. I agree on having an IT as a follow up change for verifying the end to end flow across all PRs. |
eirsep
approved these changes
Oct 4, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
* Adding WAF Log type Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> * Minor refactoring Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> * Fix duplicate keys Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> * Test fix Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> * test fix Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> * Adding custom log specific to aws waf Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> * Add Security category to waf logtype Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> --------- Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> (cherry picked from commit 115ae95)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
* Adding WAF Log type Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> * Minor refactoring Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> * Fix duplicate keys Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> * Test fix Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> * test fix Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> * Adding custom log specific to aws waf Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> * Add Security category to waf logtype Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> --------- Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> (cherry picked from commit 115ae95)
sbcd90
pushed a commit
that referenced
this pull request
Oct 5, 2023
sbcd90
pushed a commit
that referenced
this pull request
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding WAF log type as a pre-packaged rule
Issues Resolved
Resolves #573
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.