Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gradle 8.5 #720

Closed
wants to merge 1 commit into from
Closed

Conversation

reta
Copy link
Contributor

@reta reta commented Nov 16, 2023

Description

Update to Gradle 8.5

Issues Resolved

Part of opensearch-project/OpenSearch#10334

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

jowg-amazon
jowg-amazon previously approved these changes Jan 12, 2024
@eirsep
Copy link
Member

eirsep commented Jan 12, 2024

why have our test workflows not run on this?
that would give us confidence to merge

@reta
Copy link
Contributor Author

reta commented Jan 12, 2024

why have our test workflows not run on this?

No idea (question to maintainers) but thanks for looking @eirsep

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta changed the title Update to Gradle 8.4 Update to Gradle 8.5 Jan 12, 2024
@jowg-amazon
Copy link
Collaborator

Approved the workflow run.

@jowg-amazon
Copy link
Collaborator

Failing CI's are due to Lucene upgrade which should be fixed in this PR #800

@jowg-amazon
Copy link
Collaborator

Closing PR in favor of #800 which cherry-picks this PR for gradle upgrade to 8.5 because CI's were failing without both PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants