security implementation #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #78 +/- ##
============================================
- Coverage 40.71% 39.97% -0.74%
Complexity 882 882
============================================
Files 174 175 +1
Lines 6317 6436 +119
Branches 772 786 +14
============================================
+ Hits 2572 2573 +1
- Misses 3508 3626 +118
Partials 237 237
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
getsaurabh02
reviewed
Nov 4, 2022
| @@ -12,4 +12,7 @@ public class SecurityAnalyticsSettings { | |||
| public static Setting<TimeValue> INDEX_TIMEOUT = Setting.positiveTimeSetting("plugins.security_analytics.index_timeout", | |||
| TimeValue.timeValueSeconds(60), | |||
| Setting.Property.NodeScope, Setting.Property.Dynamic); | |||
|
|
|||
| public static Setting<Boolean> FILTER_BY_BACKEND_ROLES = Setting.boolSetting("plugins.security_analytics.filter_by_backend_roles", false, Setting.Property.NodeScope, Setting.Property.Dynamic); | |||
There was a problem hiding this comment.
We will need to register this setting in main Plugin file, to supply to the core.
There was a problem hiding this comment.
It is already part of SecurityAnalyticsPlugin.java, security tests will not pass otherwise
Comment on lines
89
to
92
| if ( | ||
| resourceBackendRoles == null ||requesterBackendRoles == null || | ||
| isIntersectListsEmpty(resourceBackendRoles, requesterBackendRoles) | ||
| ) { |
| import java.util.List; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| public interface SecureTransportAction { |
There was a problem hiding this comment.
Can we please add java doc here, to document the behavior
|
@raj-chak Are we still working on the multi-node build failure? |
raj-chak
force-pushed
the
security_impl
branch
from
aa98f79 to
131b359
Compare
Signed-off-by: Raj Chakravarthi <raj@icedome.ca> Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
getsaurabh02
approved these changes
Nov 7, 2022
sbcd90
approved these changes
Nov 7, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 7, 2022
Signed-off-by: Raj Chakravarthi <raj@icedome.ca> Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> (cherry picked from commit db97ea9)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 7, 2022
Signed-off-by: Raj Chakravarthi <raj@icedome.ca> Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> (cherry picked from commit db97ea9)
sbcd90
pushed a commit
that referenced
this pull request
Nov 7, 2022
sbcd90
pushed a commit
that referenced
this pull request
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Raj Chakravarthi raj@icedome.ca
Description
backend security implementation for GetDetector, Create/Update Detector and Search Detector
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.