support object fields in aggregation based sigma rules #789

sbcd90 · 2023-12-19T03:30:56Z

Description

support object fields in aggregation based sigma rules.
add support for count(field) in aggregation based sigma rules, count(*) is currently supported.
e.g.

id: 25b9c01c-350d-4b95-bed1-836d04a4f324
title: test
description: Detects when an user creates or invokes a lambda function.
status: experimental
author: test
date: 2023/12/07
modified: 2023/12/07
logsource:
  category: cloudtrail
level: low
detection:
  condition: selection1 or selection2 | count(api.operation) by cloud.region > 1
  selection1:
    api.service.name:
      - lambda.amazonaws.com
    api.operation:
      - CreateFunction
  selection2:
    api.service.name:
      - lambda.amazonaws.com
    api.operation:      
      - Invoke
  timeframe: 20m
  tags:
    - attack.privilege_escalation
    - attack.t1078

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

codecov · 2023-12-19T03:47:51Z

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (0ad91cc) 24.73% compared to head (1d4f5d7) 24.83%.
Report is 3 commits behind head on main.

Files	Patch %	Lines
...rrelation/index/codec/CorrelationCodecVersion.java	75.00%	2 Missing ⚠️
...lation990/PerFieldCorrelationVectorsFormat990.java	50.00%	2 Missing ⚠️
...ndex/codec/correlation990/CorrelationCodec990.java	85.71%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #789      +/-   ##
============================================
+ Coverage     24.73%   24.83%   +0.09%     
- Complexity     1023     1030       +7     
============================================
  Files           275      277       +2     
  Lines         12695    12713      +18     
  Branches       1400     1401       +1     
============================================
+ Hits           3140     3157      +17     
- Misses         9290     9292       +2     
+ Partials        265      264       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eirsep · 2023-12-20T07:00:17Z

src/main/grammars/Aggregation.g4

@@ -21,7 +21,7 @@ RPAREN : ')' ;

 DECIMAL : '-'?[0-9]+('.'[0-9]+)? ;

-IDENTIFIER : [a-zA-Z*_][a-zA-Z_0-9]* ;
+IDENTIFIER : [a-zA-Z*_.][a-zA-Z_0-9.]* ;


will this work for nested type fields also?

nested fields cannot be queried using query string queries.

eirsep · 2023-12-20T07:00:37Z

...generated/org/opensearch/securityanalytics/rules/condition/aggregation/AggregationLexer.java

-        "\u0000\u0000ec\u0001\u0000\u0000\u0000ef\u0001\u0000\u0000\u0000fg\u0001"+
-        "\u0000\u0000\u0000gh\u0006\u000f\u0000\u0000h \u0001\u0000\u0000\u0000"+
-        "\u0007\u0000LQWY_e\u0001\u0006\u0000\u0000";
+        "\u0000\u0004\u0001\u000009\u0005\u0000**..AZ__az\u0005\u0000..09AZ__a"+


what are these changes?

these are generated code by antlr.

eirsep · 2023-12-20T07:03:47Z

src/main/java/org/opensearch/securityanalytics/rules/backend/OSQueryBackend.java

@@ -376,17 +376,17 @@ public AggregationQueries convertAggregation(AggregationItem aggregation) {
            Script script = new Script(String.format(Locale.getDefault(), bucketTriggerScript, "_cnt", aggregation.getCompOperator(), aggregation.getThreshold()));
            condition = new BucketSelectorExtAggregationBuilder(bucketTriggerSelectorId, Collections.singletonMap("_cnt", "_count"), script, "result_agg", null);
        } else {
-            fmtAggQuery = String.format(Locale.getDefault(), aggQuery, "result_agg", aggregation.getGroupByField(), aggregation.getAggField(), aggregation.getAggFunction(), aggregation.getAggField());
-            fmtBucketTriggerQuery = String.format(Locale.getDefault(), bucketTriggerQuery, aggregation.getAggField(), aggregation.getAggField(), "result_agg", aggregation.getAggField(), aggregation.getCompOperator(), aggregation.getThreshold());
+            fmtAggQuery = String.format(Locale.getDefault(), aggQuery, "result_agg", aggregation.getGroupByField(), aggregation.getAggField().replace(".", "_"), aggregation.getAggFunction().equals("count")? "value_count": aggregation.getAggFunction(), aggregation.getAggField());


why have we changed from aggregation.getAggFunction() to aggregation.getAggFunction().equals("count")? "value_count": aggregation.getAggFunction()?
Is this intentional?

we want to support count(field). earlier, we only supported count(*).

plz update description of PR to call this out.

eirsep · 2023-12-20T07:11:01Z

src/main/java/org/opensearch/securityanalytics/rules/backend/OSQueryBackend.java

-            fmtAggQuery = String.format(Locale.getDefault(), aggQuery, "result_agg", aggregation.getGroupByField(), aggregation.getAggField(), aggregation.getAggFunction(), aggregation.getAggField());
-            fmtBucketTriggerQuery = String.format(Locale.getDefault(), bucketTriggerQuery, aggregation.getAggField(), aggregation.getAggField(), "result_agg", aggregation.getAggField(), aggregation.getCompOperator(), aggregation.getThreshold());
+            fmtAggQuery = String.format(Locale.getDefault(), aggQuery, "result_agg", aggregation.getGroupByField(), aggregation.getAggField().replace(".", "_"), aggregation.getAggFunction().equals("count")? "value_count": aggregation.getAggFunction(), aggregation.getAggField());
+            fmtBucketTriggerQuery = String.format(Locale.getDefault(), bucketTriggerQuery, aggregation.getAggField().replace(".", "_"), aggregation.getAggField(), "result_agg", aggregation.getAggField().replace(".", "_"), aggregation.getCompOperator(), aggregation.getThreshold());


plz do aggregation.getAggField().replace(".", "_") only once and store in variable and re-use everywhere else

eirsep · 2023-12-20T07:12:54Z

src/test/java/org/opensearch/securityanalytics/TestHelpers.java

@@ -1789,6 +1833,106 @@ public static String randomAdLdapDoc() {
                "}";
    }

+    public static String randomCloudtrailOcsfDoc() {


can you create a document with object type fields in a.b.c (dot) format and test the same agg rule?

ok updated the mapping to an object field. https://github.com/opensearch-project/security-analytics/pull/789/files#diff-32ce4f632f4dca5253d801824d6ac90e9fa458a73bf21a2a04f57750f98fd5c4R983

eirsep · 2023-12-20T07:25:53Z

src/main/java/org/opensearch/securityanalytics/rules/backend/OSQueryBackend.java

@@ -361,9 +361,9 @@ public AggregationQueries convertAggregation(AggregationItem aggregation) {
        BucketSelectorExtAggregationBuilder condition;
        String bucketTriggerSelectorId = UUIDs.base64UUID();

-        if (aggregation.getAggFunction().equals("count")) {
+        if (aggregation.getAggFunction().equals("count") && aggregation.getAggField().equals("*")) {


is there any edge case where field mappings need to be considered during aggregation rule parsing?

what if customer creates an aggregation rule with ECS field name?

can you add a test case where customer use ecs field name in rule and corresponding automatically mapped raw field name in index mapping

added an aggregation rule which leverages raw->ecs mapping. https://github.com/opensearch-project/security-analytics/pull/789/files#diff-87d7340297313306294ffad230b377b4b828855c8b0495784ff5e66065e86eb0R2051

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

opensearch-trigger-bot · 2024-01-16T22:42:32Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-789-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0bbdb3164084699781a58f3e0682a86b2f895b8c
# Push it to GitHub
git push --set-upstream origin backport/backport-789-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-789-to-2.x.

…oject#789) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

* support object fields in aggregation based sigma rules (#789) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * Pass rule field names in doc level queries during monitor/creation. Remove blocking actionGet() calls (#873) * pass query field names in doc level queries during monitor creation/updation Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove actionGet() and change get index mapping call to event driven flow Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix chained findings monitor Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add finding mappings Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove test messages from logs Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * revert build.gradle change Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com>

Signed-off-by: Joanne Wang <jowg@amazon.com> (cherry picked from commit 4d4f5e3) Co-authored-by: Joanne Wang <jowg@amazon.com> Reduce log level for informative message (opensearch-project#203) (opensearch-project#833) Signed-off-by: Enrico Tröger <enrico.troeger@uvena.de> Co-authored-by: Enrico Tröger <enrico.troeger@uvena.de> Updated alert creation following common-utils PR 584. (opensearch-project#837) (opensearch-project#839) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 8adb9c3) Co-authored-by: AWSHurneyt <hurneyt@amazon.com> Release notes for 2.12.0 (opensearch-project#834) (opensearch-project#841) * release notes for 2.12 Signed-off-by: Joanne Wang <jowg@amazon.com> * update release notes Signed-off-by: Joanne Wang <jowg@amazon.com> * update release notes Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com> (cherry picked from commit 414484a) Co-authored-by: Joanne Wang <jowg@amazon.com> Remove blocking calls and change threat intel feed flow to event driven (opensearch-project#871) (opensearch-project#876) * remove actionGet() and change threat intel feed flow to event driven Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix javadocs Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * revert try catch removals Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * use action listener wrap() in detector threat intel code paths Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add try catch Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit 172d58d) Co-authored-by: Surya Sashank Nistala <snistala@amazon.com> Fail the flow the when detectot type is missing in the log types index (opensearch-project#845) (opensearch-project#857) Signed-off-by: Megha Goyal <goyamegh@amazon.com> (cherry picked from commit 8d19912) Co-authored-by: Megha Goyal <56077967+goyamegh@users.noreply.github.com> [BUG] ArrayIndexOutOfBoundsException for inconsistent detector index behavior (opensearch-project#843) (opensearch-project#858) * Catch ArrayIndexOutOfBoundsException when detector is missing Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Add a check on SearchHits.getHits() length Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Remove index out of bounds exception Signed-off-by: Megha Goyal <goyamegh@amazon.com> --------- Signed-off-by: Megha Goyal <goyamegh@amazon.com> (cherry picked from commit 0ef8543) Co-authored-by: Megha Goyal <56077967+goyamegh@users.noreply.github.com> Backport opensearch-project#873 and opensearch-project#789 (opensearch-project#895) * support object fields in aggregation based sigma rules (opensearch-project#789) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * Pass rule field names in doc level queries during monitor/creation. Remove blocking actionGet() calls (opensearch-project#873) * pass query field names in doc level queries during monitor creation/updation Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove actionGet() and change get index mapping call to event driven flow Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix chained findings monitor Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add finding mappings Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove test messages from logs Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * revert build.gradle change Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Fix duplicate ecs mappings which returns incorrect log index field in mapping view API (opensearch-project#786) (opensearch-project#788) (opensearch-project#898) * field mapping changes * add integ test * turn unmappedfieldaliases as set and add integ test * add comments * fix integ tests * moved logic to method for better readability --------- Signed-off-by: Joanne Wang <jowg@amazon.com> Add throw for empty strings in rules with modifier contains, startwith, and endswith (opensearch-project#860) (opensearch-project#896) * add validation for empty strings with contains, startswith and endswith modifiers * throw exception if empty string with contains, startswith, or endswith * change var name * add modifiers to log --------- Signed-off-by: Joanne Wang <jowg@amazon.com> Add an "exists" check for "not" condition in sigma rules (opensearch-project#852) (opensearch-project#897) * test design Signed-off-by: Joanne Wang <jowg@amazon.com> * working version Signed-off-by: Joanne Wang <jowg@amazon.com> * cleaning up Signed-off-by: Joanne Wang <jowg@amazon.com> * testing Signed-off-by: Joanne Wang <jowg@amazon.com> * working version Signed-off-by: Joanne Wang <jowg@amazon.com> * working version Signed-off-by: Joanne Wang <jowg@amazon.com> * refactored querybackend Signed-off-by: Joanne Wang <jowg@amazon.com> * working on tests Signed-off-by: Joanne Wang <jowg@amazon.com> * fixed alerting and finding tests Signed-off-by: Joanne Wang <jowg@amazon.com> * fix correlation tests Signed-off-by: Joanne Wang <jowg@amazon.com> * working all tests Signed-off-by: Joanne Wang <jowg@amazon.com> * moved test and changed alias for adldap Signed-off-by: Joanne Wang <jowg@amazon.com> * added more tests Signed-off-by: Joanne Wang <jowg@amazon.com> * cleanup code Signed-off-by: Joanne Wang <jowg@amazon.com> * remove exists flag Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com> (cherry picked from commit 656a5fe) Co-authored-by: Joanne Wang <jowg@amazon.com> Add goyamegh as a maintainer (opensearch-project#868) (opensearch-project#899) Signed-off-by: Megha Goyal <goyamegh@amazon.com> Refactor invocation of Action listeners in correlations (opensearch-project#880) (opensearch-project#900) * Refactor invocation of Action listeners in correlations * Close hanging tasks in correlations workflow * Logging finding id and monitor id in error logs --------- Signed-off-by: Megha Goyal <goyamegh@amazon.com> Add search request timeouts for correlations workflows (opensearch-project#893) (opensearch-project#901) * Reinstating more leaks plugged-in for correlations workflows Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Add search timeouts to all correlation searches Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Fix logging and exception messages Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Change search timeout to 30 seconds Signed-off-by: Megha Goyal <goyamegh@amazon.com> --------- Signed-off-by: Megha Goyal <goyamegh@amazon.com> (cherry picked from commit 75c4429) Co-authored-by: Megha Goyal <56077967+goyamegh@users.noreply.github.com>

opensearch-trigger-bot · 2024-03-14T05:02:01Z

The backport to 2.11 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.11 2.11
# Navigate to the new working tree
cd .worktrees/backport-2.11
# Create a new branch
git switch --create backport/backport-789-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0bbdb3164084699781a58f3e0682a86b2f895b8c
# Push it to GitHub
git push --set-upstream origin backport/backport-789-to-2.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.11

Then, create a pull request where the base branch is 2.11 and the compare/head branch is backport/backport-789-to-2.11.

…oject#789) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

* support object fields in aggregation based sigma rules (#789) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * Fix duplicate ecs mappings which returns incorrect log index field in mapping view API (#786) (#788) * field mapping changes Signed-off-by: Joanne Wang <jowg@amazon.com> * add integ test Signed-off-by: Joanne Wang <jowg@amazon.com> * turn unmappedfieldaliases as set and add integ test Signed-off-by: Joanne Wang <jowg@amazon.com> * add comments Signed-off-by: Joanne Wang <jowg@amazon.com> * fix integ tests Signed-off-by: Joanne Wang <jowg@amazon.com> * moved logic to method for better readability Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com> * Fix get mappings view API incorrectly returning ecs path (#867) * add logic and integ tests to not add duplicate to log-types-config index Signed-off-by: Joanne Wang <jowg@amazon.com> * change naming for existingFieldMapping and change contains to equals Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com> * fix integ test (#918) Signed-off-by: Joanne Wang <jowg@amazon.com> * get all findings as part of findings API enhancement (#803) * get all findings as part of findings API enhancement Signed-off-by: Riya Saxena <riysaxen@amazon.com> * findingsAPI feature enhancements (address comments to prev PR) Signed-off-by: Riya Saxena <riysaxen@amazon.com> * findingsAPI feature enhancements (address comments to prev PR) Signed-off-by: Riya Saxena <riysaxen@amazon.com> * added support for param in Finding API Signed-off-by: Riya Saxena <riysaxen@amazon.com> * added detectionType as param for Findings API enhancements Signed-off-by: Riya Saxena <riysaxen@amazon.com> * added few tests to validate findings by params Signed-off-by: Riya Saxena <riysaxen@amazon.com> * added test for searchString param in FindingsAPI Signed-off-by: Riya Saxena <riysaxen@amazon.com> * adding addiional params findingIds, startTime and endTime as findings API enhancement Signed-off-by: Riya Saxena <riysaxen@amazon.com> * added params in getFindingsByDetectorId func * changed the startTime and endTime req input format * fix merge conflixt * fix integ test failures in findings API * fix integ tests * fix integ tests for findings Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> Signed-off-by: Riya <69919272+riysaxen-amzn@users.noreply.github.com> Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> * Feature findings api enhancements (#914) * get all findings as part of findings API enhancement Signed-off-by: Riya Saxena <riysaxen@amazon.com> * findingsAPI feature enhancements (address comments to prev PR) Signed-off-by: Riya Saxena <riysaxen@amazon.com> * findingsAPI feature enhancements (address comments to prev PR) Signed-off-by: Riya Saxena <riysaxen@amazon.com> * added support for param in Finding API Signed-off-by: Riya Saxena <riysaxen@amazon.com> * added detectionType as param for Findings API enhancements Signed-off-by: Riya Saxena <riysaxen@amazon.com> * added few tests to validate findings by params Signed-off-by: Riya Saxena <riysaxen@amazon.com> * added test for searchString param in FindingsAPI Signed-off-by: Riya Saxena <riysaxen@amazon.com> * adding addiional params findingIds, startTime and endTime as findings API enhancement Signed-off-by: Riya Saxena <riysaxen@amazon.com> * added params in getFindingsByDetectorId func * changed the startTime and endTime req input format * fix merge conflixt * fix integ test failures in findings API * fix integ tests * refactored the logic Signed-off-by: Riya Saxena <riysaxen@amazon.com> * remove unused imports * address the pr comments Signed-off-by: Riya Saxena <riysaxen@amazon.com> * address pr comments Signed-off-by: Riya Saxena <riysaxen@amazon.com> * SA integ tests fix * SA integ tests fix * fix integ tests for findings Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * fix conflixt errors Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix conflixt errors Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix conflixt errors Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix conflixt errors Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix integ tests Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix integ tests Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix integ tests Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix flaky integ tests Signed-off-by: Riya Saxena <riysaxen@amazon.com> * address pr comments Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> Signed-off-by: Riya <69919272+riysaxen-amzn@users.noreply.github.com> Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> * fix findings api integ tests Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: Joanne Wang <jowg@amazon.com> Signed-off-by: Riya Saxena <riysaxen@amazon.com> Signed-off-by: Riya <69919272+riysaxen-amzn@users.noreply.github.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Co-authored-by: Riya <69919272+riysaxen-amzn@users.noreply.github.com>

* Fix duplicate ecs mappings which returns incorrect log index field in mapping view API (#786) (#788) * field mapping changes Signed-off-by: Joanne Wang <jowg@amazon.com> * add integ test Signed-off-by: Joanne Wang <jowg@amazon.com> * turn unmappedfieldaliases as set and add integ test Signed-off-by: Joanne Wang <jowg@amazon.com> * add comments Signed-off-by: Joanne Wang <jowg@amazon.com> * fix integ tests Signed-off-by: Joanne Wang <jowg@amazon.com> * moved logic to method for better readability Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com> * support object fields in aggregation based sigma rules (#789) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * Pass rule field names in doc level queries during monitor/creation. Remove blocking actionGet() calls (#873) * pass query field names in doc level queries during monitor creation/updation Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove actionGet() and change get index mapping call to event driven flow Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix chained findings monitor Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add finding mappings Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove test messages from logs Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * revert build.gradle change Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * version bump Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * AggregationBackendTests fix Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com> Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> Signed-off-by: Riya Saxena <riysaxen@amazon.com> Co-authored-by: Joanne Wang <jowg@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>

sbcd90 requested review from amsiglan, AWSHurneyt, getsaurabh02, lezzago, praveensameneni, eirsep and jowg-amazon as code owners December 19, 2023 03:30

sbcd90 force-pushed the aggr_fixes_object branch from 056b69b to 7f1b86a Compare December 19, 2023 09:00

eirsep reviewed Dec 20, 2023

View reviewed changes

eirsep requested changes Dec 20, 2023

View reviewed changes

sbcd90 added 2 commits January 13, 2024 01:13

support object fields in aggregation based sigma rules

d626a95

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

support object fields in aggregation based sigma rules

1d4f5d7

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

sbcd90 force-pushed the aggr_fixes_object branch from 7f1b86a to 1d4f5d7 Compare January 13, 2024 09:09

eirsep approved these changes Jan 16, 2024

View reviewed changes

jowg-amazon approved these changes Jan 16, 2024

View reviewed changes

sbcd90 added the backport 2.x label Jan 16, 2024

sbcd90 merged commit 0bbdb31 into opensearch-project:main Jan 16, 2024
15 of 19 checks passed

jowg-amazon added the failed backport label Jan 18, 2024

eirsep pushed a commit to eirsep/security-analytics that referenced this pull request Mar 8, 2024

support object fields in aggregation based sigma rules (opensearch-pr…

688c0be

…oject#789) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

eirsep pushed a commit to eirsep/security-analytics that referenced this pull request Mar 8, 2024

support object fields in aggregation based sigma rules (opensearch-pr…

993b99d

…oject#789) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

eirsep mentioned this pull request Mar 8, 2024

Backport #873 and #789 #895

Merged

jowg-amazon added the backport 2.11 label Mar 14, 2024

jowg-amazon pushed a commit to jowg-amazon/security-analytics that referenced this pull request Mar 14, 2024

support object fields in aggregation based sigma rules (opensearch-pr…

6a666ca

…oject#789) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

jowg-amazon mentioned this pull request Mar 14, 2024

[Backport 2.11] Backport #789, #788, #867, and #918 to 2.11 #925

Closed

5 tasks

eirsep pushed a commit to eirsep/security-analytics that referenced this pull request Mar 14, 2024

support object fields in aggregation based sigma rules (opensearch-pr…

323989d

…oject#789) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

eirsep pushed a commit to eirsep/security-analytics that referenced this pull request Mar 14, 2024

support object fields in aggregation based sigma rules (opensearch-pr…

85b76d3

…oject#789) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

jowg-amazon pushed a commit to jowg-amazon/security-analytics that referenced this pull request Mar 14, 2024

support object fields in aggregation based sigma rules (opensearch-pr…

8bda4d1

…oject#789) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

jowg-amazon mentioned this pull request Mar 14, 2024

[Backport 2.11] Backport #789 to 2.11 #928

Closed

5 tasks

jowg-amazon pushed a commit to jowg-amazon/security-analytics that referenced this pull request Mar 15, 2024

support object fields in aggregation based sigma rules (opensearch-pr…

f11acc5

…oject#789) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

jowg-amazon mentioned this pull request Mar 15, 2024

[Backport 2.11] Backport #789, #788, #867, and #918 to 2.11 #931

Merged

5 tasks

engechas mentioned this pull request Apr 9, 2024

[BUG] Importing a Sigma rule with count() aggregation returns an error #861

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support object fields in aggregation based sigma rules #789

support object fields in aggregation based sigma rules #789

sbcd90 commented Dec 19, 2023 •

edited by jowg-amazon

Loading

codecov bot commented Dec 19, 2023 •

edited

Loading

eirsep Dec 20, 2023

sbcd90 Jan 13, 2024 •

edited

Loading

eirsep Dec 20, 2023

sbcd90 Jan 13, 2024

eirsep Dec 20, 2023

sbcd90 Jan 13, 2024

eirsep Jan 14, 2024

eirsep Dec 20, 2023

sbcd90 Jan 13, 2024

eirsep Dec 20, 2023

sbcd90 Jan 13, 2024

eirsep Dec 20, 2023 •

edited

Loading

sbcd90 Jan 13, 2024 •

edited

Loading

opensearch-trigger-bot bot commented Jan 16, 2024

opensearch-trigger-bot bot commented Mar 14, 2024

support object fields in aggregation based sigma rules #789

support object fields in aggregation based sigma rules #789

Conversation

sbcd90 commented Dec 19, 2023 • edited by jowg-amazon Loading

Description

Issues Resolved

Check List

codecov bot commented Dec 19, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

sbcd90 Jan 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eirsep Dec 20, 2023 • edited Loading

Choose a reason for hiding this comment

sbcd90 Jan 13, 2024 • edited Loading

Choose a reason for hiding this comment

opensearch-trigger-bot bot commented Jan 16, 2024

opensearch-trigger-bot bot commented Mar 14, 2024

sbcd90 commented Dec 19, 2023 •

edited by jowg-amazon

Loading

codecov bot commented Dec 19, 2023 •

edited

Loading

sbcd90 Jan 13, 2024 •

edited

Loading

eirsep Dec 20, 2023 •

edited

Loading

sbcd90 Jan 13, 2024 •

edited

Loading