Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollover for alerts/findings history indices #82

Merged
merged 21 commits into from
Nov 3, 2022
Merged

Rollover for alerts/findings history indices #82

merged 21 commits into from
Nov 3, 2022

Conversation

petardz
Copy link
Contributor

@petardz petardz commented Oct 26, 2022

Signed-off-by: Petar Dzepina petar.dzepina@gmail.com

Description

Rollover for alerts/findings history indices

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@petardz
initial commit
b49c41d 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz petardz requested a review from a team October 26, 2022 22:08
@petardz
rename
e07a40f 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
more tests; Added allAlertsIndicesPattern when calling GetAlerts API
c3e027b 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
forbiddenAPI task fix
b39f588 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
refactor
4ecea2a 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
fixes
28e5121 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
IT fix
b4ca7b9 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
ITs fix
ba905dd 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
empty commit
1edc6d1 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
fix IT
97716ec 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
Copy link
Contributor Author

petardz commented Oct 28, 2022

After alerting 2.4 distribution is built, tests will pass.

@petardz
licence fix
b99dda2 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
getsaurabh02
getsaurabh02 reviewed Oct 28, 2022
View reviewed changes
Copy link
Member

@getsaurabh02 getsaurabh02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have the naming consistent for other indices in SAP with a common prefix as well in such as :
/.opensearch-detectors-config
/.opensearch-pre-packaged-rules-config
/.opensearch-custom-rules-config

@petardz
renamed indices for consistent naming
6793bd6 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
empty commit
3eaf0d0 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz petardz force-pushed the alerts_findings_rollover branch from 8d20945 to 3eaf0d0 Compare October 28, 2022 23:01
@petardz
DetectorIndexManagmentService is LifecycleComponent now
38dbd38 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
empty commit
7e5139c 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2022 •
edited
Loading

Codecov Report

Merging #82 (8e483e6) into main (bfb2b23) will decrease coverage by 2.01%.
The diff coverage is 4.73%.

@@             Coverage Diff              @@
##               main      #82      +/-   ##
============================================
- Coverage     42.65%   40.63%   -2.02%     
+ Complexity      882      878       -4     
============================================
  Files           173      174       +1     
  Lines          6023     6317     +294     
  Branches        750      772      +22     
============================================
- Hits           2569     2567       -2     
- Misses         3217     3511     +294     
- Partials        237      239       +2
Impacted Files Coverage Δ
...rch/securityanalytics/SecurityAnalyticsPlugin.java 0.00% <0.00%> (ø)
...search/securityanalytics/alerts/AlertsService.java 21.90% <0.00%> (ø)
...indexmanagment/DetectorIndexManagementService.java 0.00% <0.00%> (ø)
...yanalytics/settings/SecurityAnalyticsSettings.java 0.00% <0.00%> (ø)
...alytics/config/monitors/DetectorMonitorConfig.java 55.55% <51.72%> (-1.59%) ⬇️
...g/opensearch/securityanalytics/model/Detector.java 69.45% <0.00%> (-1.82%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

getsaurabh02
getsaurabh02 previously approved these changes Oct 31, 2022
View reviewed changes
@petardz
minor fixes
b7f19be 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
eirsep
eirsep previously approved these changes Nov 1, 2022
View reviewed changes
@petardz
empty commit
b05c7d8 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
getsaurabh02
getsaurabh02 previously approved these changes Nov 1, 2022
View reviewed changes
@petardz
empty commit
642d5b3 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
merge from main
0b82daa 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz
Merge branch 'main' of https://github.com/petardz/security-analytics …
3a6adc4 
…into alerts_findings_rollover
@petardz
merge from main
8e483e6 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@eirsep eirsep merged commit 95f8d9a into opensearch-project:main Nov 3, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 3, 2022
@petardz @github-actions
Rollover for alerts/findings history indices (#82)
aceae5a 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 95f8d9a)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 3, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 3, 2022
@petardz @github-actions
Rollover for alerts/findings history indices (#82)
c190231 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 95f8d9a)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 3, 2022
Merged
eirsep pushed a commit that referenced this pull request Nov 3, 2022
@opensearch-trigger-bot @petardz
Rollover for alerts/findings history indices (#82) (#108)
c415338 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 95f8d9a)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
eirsep pushed a commit that referenced this pull request Nov 3, 2022
@opensearch-trigger-bot @petardz
Rollover for alerts/findings history indices (#82) (#109)
014715e 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit 95f8d9a)

Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
phaseshiftg pushed a commit to phaseshiftg/security-analytics that referenced this pull request Nov 5, 2022
@petardz @phaseshiftg
Rollover for alerts/findings history indices (opensearch-project#82)
a7e5253 
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eirsep eirsep eirsep approved these changes

@sbcd90 sbcd90 sbcd90 approved these changes

@getsaurabh02 getsaurabh02 getsaurabh02 left review comments

Assignees
No one assigned
Labels
backport 2.x backport 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@petardz @codecov-commenter @sbcd90 @eirsep @getsaurabh02