[Backport 2.9] Add throw for empty strings in rules with modifier contains, startwith, and endswith #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…h, and endswith (#860) * add validation for empty strings with contains, startswith and endswith modifiers Signed-off-by: Joanne Wang <jowg@amazon.com> * throw exception if empty string with contains, startswith, or endswith Signed-off-by: Joanne Wang <jowg@amazon.com> * change var name Signed-off-by: Joanne Wang <jowg@amazon.com> * add modifiers to log Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com> (cherry picked from commit f4ee7bb)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.9 #886 +/- ##
============================================
+ Coverage 25.74% 25.78% +0.03%
- Complexity 939 945 +6
============================================
Files 252 252
Lines 10746 10750 +4
Branches 1197 1199 +2
============================================
+ Hits 2767 2772 +5
+ Misses 7733 7732 -1
Partials 246 246 ☔ View full report in Codecov by Sentry. |
goyamegh
approved these changes
Mar 12, 2024
jowg-amazon
approved these changes
Mar 12, 2024
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Mar 25, 2024
…ch-project#965) * Added rest layer for the workflow. Added secure tests (opensearch-project#886) * Added rest layer for the workflow. Added secure tests * add execution_id field in alert mapping --------- Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com> Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> Co-authored-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport f4ee7bb from #860