Creates bucket level monitors for rules containing aggregations #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c for creating bucket level monitors Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com>
Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com>
stevanbz
force-pushed
the
feature/add-bucket-level-monitors
branch
2 times, most recently
from
357aaa0 to
fd8c6f5
Compare
Added integration tests for checking update of bucket level monitors Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com>
stevanbz
force-pushed
the
feature/add-bucket-level-monitors
branch
from
16b0781 to
658f353
Compare
Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com>
…name Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com>
Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com>
stevanbz
commented
Nov 7, 2022
| // Build query string filter | ||
| .query(QueryBuilders.queryStringQuery(rule.getQueries().get(0).getValue())) | ||
| .aggregation(aggregationQueries.getAggBuilder()) | ||
| .size(10000); |
Codecov Report
@@ Coverage Diff @@
## main #92 +/- ##
============================================
- Coverage 40.71% 39.79% -0.93%
- Complexity 882 886 +4
============================================
Files 174 175 +1
Lines 6317 6551 +234
Branches 772 796 +24
============================================
+ Hits 2572 2607 +35
- Misses 3508 3704 +196
- Partials 237 240 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eirsep
requested changes
Nov 7, 2022
| @@ -90,6 +97,8 @@ public class Detector implements Writeable, ToXContentObject { | |||
|
|
|||
| private List<String> monitorIds; | |||
|
|
|||
| private Map<String, String> ruleIdMonitorId; | |||
There was a problem hiding this comment.
let's have the suffix map in variable name for better readability
mayberuleIdMonitorIdMap
| @@ -73,7 +72,7 @@ public void testCountAggregationWithGroupBy() throws IOException, SigmaError { | |||
| String aggQuery = aggQueries.getAggQuery(); | |||
| String bucketTriggerQuery = aggQueries.getBucketTriggerQuery(); | |||
|
|
|||
| Assert.assertEquals("\"aggs\":{\"result_agg\":{\"terms\":{\"field\":\"fieldB\"}}}", aggQuery); | |||
There was a problem hiding this comment.
how was this assert working if you needed to change the structuring of the fields
There was a problem hiding this comment.
You can see one line below that I just removed aggs part ie.
Assert.assertEquals("{"result_agg":{"terms":{"field":"fieldB"}}}", aggQuery);
| aggregationBuilder = new ValueCountAggregationBuilder(name).field(name); | ||
| break; | ||
| default: | ||
| return null; |
There was a problem hiding this comment.
let's surface a not supported exception for better debugging.
Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com>
eirsep
changed the title
|
LGTM |
Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com>
Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com>
eirsep
approved these changes
Nov 9, 2022
sbcd90
approved these changes
Nov 9, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 9, 2022
Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com> (cherry picked from commit 2f0abe6)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 9, 2022
Signed-off-by: Stevan Buzejic <stevan.buzejic@htecgroup.com> (cherry picked from commit 2f0abe6)
eirsep
pushed a commit
that referenced
this pull request
Nov 9, 2022
eirsep
pushed a commit
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables creation of bucket level monitors based on the aggregation rules.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.