Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add findings enabled flag in datasources #99

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Nov 2, 2022

Signed-off-by: Surya Sashank Nistala snistala@amazon.com

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@eirsep eirsep requested a review from a team November 2, 2022 18:24
@eirsep eirsep changed the base branch from main to 2.x November 2, 2022 18:29
@eirsep eirsep changed the base branch from 2.x to main November 2, 2022 18:29
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Merging #99 (9e8bf29) into main (65395db) will increase coverage by 0.07%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main      #99      +/-   ##
============================================
+ Coverage     43.13%   43.20%   +0.07%     
- Complexity      855      859       +4     
============================================
  Files           167      167              
  Lines          5826     5828       +2     
  Branches        734      734              
============================================
+ Hits           2513     2518       +5     
+ Misses         3079     3078       -1     
+ Partials        234      232       -2     
Impacted Files Coverage Δ
...lytics/transport/TransportIndexDetectorAction.java 0.00% <0.00%> (ø)
...g/opensearch/securityanalytics/model/Detector.java 71.27% <0.00%> (+1.81%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eirsep eirsep merged commit d1f62cc into opensearch-project:main Nov 2, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 2, 2022
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit d1f62cc)
eirsep added a commit that referenced this pull request Nov 3, 2022
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit d1f62cc)

Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 3, 2022
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit d1f62cc)
eirsep added a commit that referenced this pull request Nov 3, 2022
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit d1f62cc)

Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants