-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OpenSearch logo theming for light / dark modes #1568
Conversation
d11044a
to
f6b0dc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AMoo-Miki This change looks good to me. The failing integ tests are unrelated to this change and currently being worked on: opensearch-project/security#3272
@AMoo-Miki Can you address the failing unit tests in
|
Signed-off-by: Miki <miki@amazon.com>
f6b0dc7
to
75e295a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1568 +/- ##
=======================================
Coverage 66.18% 66.18%
=======================================
Files 93 93
Lines 2339 2339
Branches 312 312
=======================================
Hits 1548 1548
Misses 722 722
Partials 69 69
|
@AMoo-Miki Do you want to get this in for 2.10? The window is closing in pretty fast |
@peternied This is blocked by opensearch-project/security#3278 Once the security PR is merged I will re-run the CI |
Issue from the security plugin has been merged into main [1], I've retriggered the integration tests. |
Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit ecb15d5)
Description
This change uses the imagery exposed by OSD for the login screen.
Issues Resolved
#1529
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.