Add permissions for async query and patch datasource API #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmmusings
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997 and
stephen-crawford
as code owners
stephen-crawford
added
backport 2.x
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1626 +/- ##
=======================================
Coverage 67.99% 67.99%
=======================================
Files 93 93
Lines 2340 2340
Branches 317 317
=======================================
Hits 1591 1591
Misses 720 720
Partials 29 29
|
DarshitChanpura
approved these changes
Oct 23, 2023
RyanL1997
approved these changes
Oct 24, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit c784665)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit c784665)
cwperks
pushed a commit
that referenced
this pull request
Oct 24, 2023
DarshitChanpura
pushed a commit
that referenced
this pull request
Oct 24, 2023
70 tasks
cwperks
added a commit
to cwperks/security-dashboards-plugin
that referenced
this pull request
Nov 6, 2023
cwperks
added a commit
that referenced
this pull request
Nov 6, 2023
leanneeliatra
pushed a commit
to leanneeliatra/security-dashboards-plugin-fork
that referenced
this pull request
Nov 17, 2023
…project#1626) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new permissions introduced for async query and patch datasource APIs.
Category
Enhancement
Why these changes are required?
These are required to ensure customer can set required permissions to user roles for async query apis and new patch datasource API.
What is the old behavior before changes and new behavior after changes?
Issues Resolved
[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]
Testing
Manually tested.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.