Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding @derek-ho as a maintainer #1842

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Mar 21, 2024

Description

@derek-ho has been an avid contributor to the security-dashboards-plugin repo since June '23 with 19 Pull Requests merged into main to date. Derek regularly engages on Pull Requests by giving other contributors valuable feedback, helps to maintain all release branches with critical bug fixes and ensuring dependencies are free of known security vulnerabilities, and contributes new features to the security-dashboards-plugin. Some of @derek-ho's notable contributions include:

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard @derek-ho !

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.04%. Comparing base (3bff6db) to head (d4a4495).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1842   +/-   ##
=======================================
  Coverage   68.04%   68.04%           
=======================================
  Files          94       94           
  Lines        2422     2422           
  Branches      330      330           
=======================================
  Hits         1648     1648           
  Misses        696      696           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DarshitChanpura
Copy link
Member

We have approvals from all maintainers.

@DarshitChanpura DarshitChanpura merged commit aa77c59 into opensearch-project:main Mar 26, 2024
15 checks passed
@peternied
Copy link
Member

@cwperks Could you update the code owners file and then ask the admin team to make the settings change on the repo?

@cwperks
Copy link
Member Author

cwperks commented Mar 26, 2024

@peternied TY, I opened a PR to add @derek-ho to CODEOWNERS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants