[Backport 1.3] Fix a bug where basepath nextUrl is invalid when it should be valid #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…2096) * Fix a bug where basepath nextUrl is invalid when it should be valid Signed-off-by: Derek Ho <dxho@amazon.com> * Udpate test Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit b1148fb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho
approved these changes
Aug 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.3 #2098 +/- ##
=======================================
Coverage 72.48% 72.48%
=======================================
Files 88 88
Lines 1926 1926
Branches 251 251
=======================================
Hits 1396 1396
Misses 474 474
Partials 56 56 ☔ View full report in Codecov by Sentry. |
cwperks
pushed a commit
to cwperks/security-dashboards-plugin
that referenced
this pull request
Aug 22, 2024
…pensearch-project#2096) (opensearch-project#2098) * Fix a bug where basepath nextUrl is invalid when it should be valid * Udpate test --------- (cherry picked from commit b1148fb) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b1148fb from #2096.