Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature/Extension] 100% Code coverage of OBO Authenticator and Jwt Vendor #3101

Closed
3 tasks done
Tracked by #2573
RyanL1997 opened this issue Aug 4, 2023 · 0 comments · Fixed by #3428
Closed
3 tasks done
Tracked by #2573

[Feature/Extension] 100% Code coverage of OBO Authenticator and Jwt Vendor #3101

RyanL1997 opened this issue Aug 4, 2023 · 0 comments · Fixed by #3428
Assignees
@RyanL1997
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@RyanL1997
Copy link
Collaborator

RyanL1997 commented Aug 4, 2023 •
edited
Loading

Description

We should have 100% code coverage of

There should be at least 80% coverage on the following: Covered by the integration test
@RyanL1997 RyanL1997 added enhancement New feature or request untriaged Require the attention of the repository maintainers and may need to be prioritized labels Aug 4, 2023
@cwperks cwperks added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Aug 7, 2023
@peternied peternied mentioned this issue Aug 16, 2023
Closed
35 tasks
@peternied peternied mentioned this issue Aug 25, 2023
Merged
3 tasks
@RyanL1997 RyanL1997 self-assigned this Sep 28, 2023
@RyanL1997 RyanL1997 mentioned this issue Sep 29, 2023
Merged
3 tasks
stephen-crawford pushed a commit that referenced this issue Oct 12, 2023
@RyanL1997 @DarshitChanpura
Code coverage of OBO Authentication (#3428)
387c8a5 
### Description
Code coverage of OBO Authentication
* Category (Enhancement, New feature, Bug fix, Test fix, Refactoring,
Maintenance, Documentation)
Enhancement

### Issues Resolved
* Resolve #3101

### Check List
- [x] New functionality includes testing
- [ ] New functionality has been documented
- [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Co-authored-by: Darshit Chanpura <dchanp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanL1997 RyanL1997

Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Code coverage of OBO Authentication RyanL1997/security
2 participants
@cwperks @RyanL1997