-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update checkNullElementsInArray()
unit test to check both error message and error code instead of only checking the error code
#1370
Merged
vrozov
merged 4 commits into
opensearch-project:main
from
afazel:fix_checkNullElementsInArray_UT
Aug 12, 2021
Merged
Update checkNullElementsInArray()
unit test to check both error message and error code instead of only checking the error code
#1370
vrozov
merged 4 commits into
opensearch-project:main
from
afazel:fix_checkNullElementsInArray_UT
Aug 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1370 +/- ##
=========================================
Coverage 64.80% 64.81%
- Complexity 3201 3202 +1
=========================================
Files 247 247
Lines 17243 17243
Branches 3050 3050
=========================================
+ Hits 11175 11176 +1
Misses 4517 4517
+ Partials 1551 1550 -1
Continue to review full report at Codecov.
|
vrozov
reviewed
Aug 3, 2021
src/test/java/org/opensearch/security/dlic/rest/api/RolesMappingApiTest.java
Outdated
Show resolved
Hide resolved
vrozov
previously approved these changes
Aug 6, 2021
palashhedau
reviewed
Aug 6, 2021
src/test/java/org/opensearch/security/dlic/rest/api/RolesApiTest.java
Outdated
Show resolved
Hide resolved
andy840314
previously approved these changes
Aug 6, 2021
afazel
force-pushed
the
fix_checkNullElementsInArray_UT
branch
2 times, most recently
from
August 9, 2021 21:45
eff5c14
to
8093dcf
Compare
vrozov
reviewed
Aug 9, 2021
src/test/java/org/opensearch/security/dlic/rest/api/RolesApiTest.java
Outdated
Show resolved
Hide resolved
afazel
force-pushed
the
fix_checkNullElementsInArray_UT
branch
from
August 9, 2021 23:22
8093dcf
to
e0fc3f1
Compare
palashhedau
previously approved these changes
Aug 9, 2021
afazel
force-pushed
the
fix_checkNullElementsInArray_UT
branch
from
August 10, 2021 18:56
822bf31
to
e2c7f4a
Compare
vrozov
reviewed
Aug 10, 2021
src/test/java/org/opensearch/security/dlic/rest/api/ActionGroupsApiTest.java
Outdated
Show resolved
Hide resolved
palashhedau
previously approved these changes
Aug 11, 2021
afazel
force-pushed
the
fix_checkNullElementsInArray_UT
branch
from
August 11, 2021 16:01
e2c7f4a
to
caa65bd
Compare
vrozov
reviewed
Aug 11, 2021
src/test/java/org/opensearch/security/dlic/rest/api/ActionGroupsApiTest.java
Outdated
Show resolved
Hide resolved
afazel
force-pushed
the
fix_checkNullElementsInArray_UT
branch
from
August 11, 2021 16:59
caa65bd
to
f56281b
Compare
vrozov
reviewed
Aug 11, 2021
src/test/java/org/opensearch/security/dlic/rest/api/RolesMappingApiTest.java
Outdated
Show resolved
Hide resolved
afazel
force-pushed
the
fix_checkNullElementsInArray_UT
branch
from
August 11, 2021 17:38
f56281b
to
c37e18c
Compare
vrozov
approved these changes
Aug 11, 2021
palashhedau
approved these changes
Aug 11, 2021
afazel
added a commit
to afazel/security
that referenced
this pull request
Aug 12, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370) (cherry picked from commit 0a2916b)
afazel
added a commit
to afazel/security
that referenced
this pull request
Aug 13, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370) (cherry picked from commit 0a2916b)
AMoo-Miki
pushed a commit
to AMoo-Miki/security
that referenced
this pull request
Aug 13, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)
afazel
added a commit
to afazel/security
that referenced
this pull request
Aug 17, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370) (cherry picked from commit 0a2916b)
afazel
added a commit
to afazel/security
that referenced
this pull request
Aug 18, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370) (cherry picked from commit 0a2916b)
afazel
added a commit
to afazel/security
that referenced
this pull request
Aug 19, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370) (cherry picked from commit 0a2916b)
afazel
added a commit
to afazel/security
that referenced
this pull request
Aug 19, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370) (cherry picked from commit 0a2916b)
afazel
added a commit
to afazel/security
that referenced
this pull request
Aug 19, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370) (cherry picked from commit 0a2916b)
afazel
added a commit
to afazel/security
that referenced
this pull request
Aug 19, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370) (cherry picked from commit 0a2916b)
afazel
added a commit
to afazel/security
that referenced
this pull request
Aug 19, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370) (cherry picked from commit 0a2916b)
afazel
added a commit
to afazel/security
that referenced
this pull request
Aug 19, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370) (cherry picked from commit 0a2916b)
afazel
added a commit
to afazel/security
that referenced
this pull request
Aug 19, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370) (cherry picked from commit 0a2916b)
afazel
added a commit
to afazel/security
that referenced
this pull request
Aug 24, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370) (cherry picked from commit 0a2916b)
afazel
added a commit
to afazel/security
that referenced
this pull request
Aug 24, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370) (cherry picked from commit 0a2916b)
afazel
added a commit
to afazel/security
that referenced
this pull request
Aug 24, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370) (cherry picked from commit 0a2916b)
afazel
added a commit
to afazel/security
that referenced
this pull request
Aug 24, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370) (cherry picked from commit 0a2916b)
afazel
added a commit
to afazel/security
that referenced
this pull request
Aug 24, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370) (cherry picked from commit 0a2916b)
afazel
added a commit
to afazel/security
that referenced
this pull request
Aug 24, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370) (cherry picked from commit 0a2916b)
lbreinig
pushed a commit
to lbreinig/security
that referenced
this pull request
Dec 23, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
…sage and error code instead of only checking the error code (opensearch-project#1370)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opensearch-security pull request intake form
Please provide as much details as possible to get feedback/acceptance on your PR quickly
Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Bug fix
Github Issue # or road-map entry, if available:
Description of changes:
Currently
checkNullElementsInArray()
unit test only checks for the error code and it will pass even if request fails for a different reason. We need to check the error message to make sure that the message is also what we expect.Why these changes are required?
To make sure that the test is not passing if the request fails for a different reason.
What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)
In the new behavior, the unit test will pass only if error code and the error message are what we expected.
Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)
TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)
Is it backport from main branch? (If yes, please add backport PR # and commits #)
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.