Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checkNullElementsInArray() unit test to check both error message and error code instead of only checking the error code #1370

Merged

Conversation

afazel
Copy link
Contributor

@afazel afazel commented Aug 3, 2021

opensearch-security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

  1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
    Bug fix

  2. Github Issue # or road-map entry, if available:

  3. Description of changes:
    Currently checkNullElementsInArray() unit test only checks for the error code and it will pass even if request fails for a different reason. We need to check the error message to make sure that the message is also what we expect.

  4. Why these changes are required?
    To make sure that the test is not passing if the request fails for a different reason.

  5. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)
    In the new behavior, the unit test will pass only if error code and the error message are what we expected.

  6. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

  7. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

  8. Is it backport from main branch? (If yes, please add backport PR # and commits #)

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@afazel afazel requested a review from a team August 3, 2021 00:20
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2021

Codecov Report

Merging #1370 (c37e18c) into main (9f04635) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1370   +/-   ##
=========================================
  Coverage     64.80%   64.81%           
- Complexity     3201     3202    +1     
=========================================
  Files           247      247           
  Lines         17243    17243           
  Branches       3050     3050           
=========================================
+ Hits          11175    11176    +1     
  Misses         4517     4517           
+ Partials       1551     1550    -1     
Impacted Files Coverage Δ
...a/org/opensearch/security/tools/SecurityAdmin.java 47.52% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f04635...c37e18c. Read the comment docs.

vrozov
vrozov previously approved these changes Aug 6, 2021
andy840314
andy840314 previously approved these changes Aug 6, 2021
@afazel afazel dismissed stale reviews from andy840314 and vrozov via eff5c14 August 9, 2021 18:35
@afazel afazel force-pushed the fix_checkNullElementsInArray_UT branch 2 times, most recently from eff5c14 to 8093dcf Compare August 9, 2021 21:45
@afazel afazel force-pushed the fix_checkNullElementsInArray_UT branch from 8093dcf to e0fc3f1 Compare August 9, 2021 23:22
palashhedau
palashhedau previously approved these changes Aug 9, 2021
palashhedau
palashhedau previously approved these changes Aug 11, 2021
@afazel afazel force-pushed the fix_checkNullElementsInArray_UT branch from caa65bd to f56281b Compare August 11, 2021 16:59
@afazel afazel force-pushed the fix_checkNullElementsInArray_UT branch from f56281b to c37e18c Compare August 11, 2021 17:38
@vrozov vrozov merged commit 0a2916b into opensearch-project:main Aug 12, 2021
afazel added a commit to afazel/security that referenced this pull request Aug 12, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)

(cherry picked from commit 0a2916b)
afazel added a commit to afazel/security that referenced this pull request Aug 13, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)

(cherry picked from commit 0a2916b)
AMoo-Miki pushed a commit to AMoo-Miki/security that referenced this pull request Aug 13, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)
afazel added a commit to afazel/security that referenced this pull request Aug 17, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)

(cherry picked from commit 0a2916b)
afazel added a commit to afazel/security that referenced this pull request Aug 18, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)

(cherry picked from commit 0a2916b)
afazel added a commit to afazel/security that referenced this pull request Aug 19, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)

(cherry picked from commit 0a2916b)
afazel added a commit to afazel/security that referenced this pull request Aug 19, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)

(cherry picked from commit 0a2916b)
afazel added a commit to afazel/security that referenced this pull request Aug 19, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)

(cherry picked from commit 0a2916b)
afazel added a commit to afazel/security that referenced this pull request Aug 19, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)

(cherry picked from commit 0a2916b)
afazel added a commit to afazel/security that referenced this pull request Aug 19, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)

(cherry picked from commit 0a2916b)
afazel added a commit to afazel/security that referenced this pull request Aug 19, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)

(cherry picked from commit 0a2916b)
afazel added a commit to afazel/security that referenced this pull request Aug 19, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)

(cherry picked from commit 0a2916b)
afazel added a commit to afazel/security that referenced this pull request Aug 24, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)

(cherry picked from commit 0a2916b)
afazel added a commit to afazel/security that referenced this pull request Aug 24, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)

(cherry picked from commit 0a2916b)
afazel added a commit to afazel/security that referenced this pull request Aug 24, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)

(cherry picked from commit 0a2916b)
afazel added a commit to afazel/security that referenced this pull request Aug 24, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)

(cherry picked from commit 0a2916b)
afazel added a commit to afazel/security that referenced this pull request Aug 24, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)

(cherry picked from commit 0a2916b)
afazel added a commit to afazel/security that referenced this pull request Aug 24, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)

(cherry picked from commit 0a2916b)
lbreinig pushed a commit to lbreinig/security that referenced this pull request Dec 23, 2021
…sage and error code instead of only checking the error code (opensearch-project#1370)
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
…sage and error code instead of only checking the error code (opensearch-project#1370)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants