[WIP]Mechanism to push zip plugins. #1757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> Adding code block for maven plugin zips Signed-off-by: pgodithi <pgodithi@amazon.com> Adding code block for maven plugin zips Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com> zip maven publish Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Closed
38 tasks
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
peternied
requested changes
Apr 12, 2022
There was a problem hiding this comment.
First of all, this is a great win for publishing, thank you for taking this on. However, I don't think we should have so much code/tooling that is within our repository. I think the suggestion to move to core is a good idea to ensure this functionality is easier to own and test.
I see imagine seeing this pull request change into a slimmer version that involves plugin the build scripts of core into our base build.gradle
|
[Triage] We haven't seen an update on this issue. |
|
Hey @peternied, thanks for closing this PR, the task to publish the zip files to maven repo is being done as a custom plugin which is in the core repo, the PR is under review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add mechanism to publish created distribution plugin zip to maven staging repo and then using CI these zips will be published public nexus maven repo. Users can consume these zips using generated maven coordinates and use them in a dependency model.
Issues Resolved
opensearch-project/opensearch-build#1916
Is this a backport?
YES
f3669bc
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.