ComplianceAuditlogTest to use signal/wait #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently with the build changes we have been seeing some increased test failures. Look at the biggest contributors its been the audit tests. By switching to the established `doThenWaitForMessage` this should improve test reliability considerably. Signed-off-by: Peter Nied <petern@amazon.com>
|
Before converting to a pull request that we merge, want to double check the CI test failures counts and make sure this was an improvement when run via GitHub Actions |
peternied
commented
Jun 24, 2022
| Assert.assertTrue(TestAuditlogImpl.messages.isEmpty()); | ||
| Assert.assertTrue(validateMsgs(TestAuditlogImpl.messages)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testUpdatePerf() throws Exception { |
There was a problem hiding this comment.
This test has been removed because it doesn't verify any behavior of audit logs, all of the functionality has been commented out. Even with the commented out code added back in, that code does not include any verification or 'performance comparisons'.
Implementing perf tests is difficult to do well - I do not recommend that we invest or build on perf testing scenarios.
DarshitChanpura
approved these changes
Jun 27, 2022
| @Override | ||
| public boolean isHandlingBackpressure() { | ||
| return true; | ||
| } | ||
|
|
||
| public static class MessagesNotFoundException extends RuntimeException { |
cliu123
approved these changes
Jun 27, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 27, 2022
Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit d507ebb)
DarshitChanpura
pushed a commit
to DarshitChanpura/security
that referenced
this pull request
Jun 27, 2022
Signed-off-by: Peter Nied <petern@amazon.com>
DarshitChanpura
pushed a commit
that referenced
this pull request
Jun 27, 2022
3 tasks
6 tasks
stephen-crawford
pushed a commit
to stephen-crawford/security
that referenced
this pull request
Nov 10, 2022
Signed-off-by: Peter Nied <petern@amazon.com> Signed-off-by: Stephen Crawford <steecraw@amazon.com>
3 tasks
peternied
added a commit
that referenced
this pull request
Dec 6, 2022
Windows build and test support for 1.3 - Use most recent format of CI workflows from main - Backport #2206 - Supply workarounds for JDK8 incompatible APIs for Encoding / Pattern matching (Thanks @cwperks!) - Backport only freeport logic from #1638 - Backport #1758 - All updates to TestAuditlogImpl.java from main - #2180 - #1935 - #1920 - #1914 - #1829 - And Targeted test updates for ComplianceAuditlogTest and BasicAuditlogTest to keep up with TestAuditlogImpl.java updates Signed-off-by: Peter Nied <petern@amazon.com> Signed-off-by: Stephen Crawford <steecraw@amazon.com> Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
…pensearch-project#1915) Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit d507ebb) Co-authored-by: Peter Nied <petern@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently with the build changes we have been seeing some increased test
failures. Look at the biggest contributors its been the audit tests.
By switching to the established
doThenWaitForMessagethis shouldimprove test reliability considerably.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.