[Backport 2.x] testComplianceEnable supports variable number of audit messages #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
We were seeing test failures where on higher end computers there would be duplicate audit messages for the index mapping creation. Then when run inside GitHub Actions there would only be 2 messages. This doesn't look like an overt product issue, overlogging of requests, but the test case was not handling it well. Also improved the failure message response for faster future debugging. Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit 1904db5)
Codecov Report
@@ Coverage Diff @@
## 2.x #1924 +/- ##
============================================
+ Coverage 60.95% 61.04% +0.08%
- Complexity 3231 3236 +5
============================================
Files 256 256
Lines 18087 18088 +1
Branches 3224 3224
============================================
+ Hits 11025 11041 +16
+ Misses 5478 5467 -11
+ Partials 1584 1580 -4
Continue to review full report at Codecov.
|
|
Ran into a new blocking failure, restarting the tests. |
6 tasks
peternied
approved these changes
Jun 29, 2022
peternied
added a commit
that referenced
this pull request
Jun 30, 2022
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
…search-project#1920) (opensearch-project#1924) We were seeing test failures where on higher end computers there would be duplicate audit messages for the index mapping creation. Then when run inside GitHub Actions there would only be 2 messages. This doesn't look like an overt product issue, overlogging of requests, but the test case was not handling it well. Also improved the failure message response for faster future debugging. Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit 1904db5) Co-authored-by: Peter Nied <petern@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1904db5 from #1920