Point in time security changes #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
peternied
approved these changes
Aug 3, 2022
47 tasks
|
@opensearch-project/security Can we get another review on this change? |
@Bukhtawar Can you please take a look at this? |
cliu123
approved these changes
Aug 9, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
Signed-off-by: Bharathwaj G <bharath78910@gmail.com> (cherry picked from commit 9ce8b4f)
Bukhtawar
reviewed
Aug 9, 2022
| @@ -130,6 +131,8 @@ cluster_composite_ops_ro: | |||
| - "indices:admin/aliases/get*" | |||
| - "indices:data/read/scroll" | |||
| - "indices:admin/resolve/index" | |||
| - "indices:data/read/point_in_time/read*" | |||
There was a problem hiding this comment.
What does read* mean, Is it read all pits if yes should we name it different to avoid confusion with index data read
peternied
pushed a commit
that referenced
this pull request
Aug 9, 2022
|
Updated security changes : #2033 |
stephen-crawford
pushed a commit
to stephen-crawford/security
that referenced
this pull request
Nov 10, 2022
Signed-off-by: Bharathwaj G <bharath78910@gmail.com> Signed-off-by: Stephen Crawford <steecraw@amazon.com>
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
…project#2005) Signed-off-by: Bharathwaj G <bharath78910@gmail.com> (cherry picked from commit 9ce8b4f) Co-authored-by: Bharathwaj G <58062316+bharath-techie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds point in time permissions to default action groups.
Point in time has 3 apis:
The permission model is similar to scroll which is a similar pagination feature
Cluster_composite_ops_ro:
Adding 'create pit' and 'list all pits' API permission to cluster composite ops read only action group.
Cluster_composite_ops:
Adding 'delete' API permission + above permissions to cluster composite ops action group.
Kibana_server:
Kibana server has access to all operations.
API changes links :
opensearch-project/OpenSearch#4064 - create pit and delete pit api
opensearch-project/OpenSearch#4016 - list all
New feature - Point in time feature
These changes are required for access of various point in time APIs
This is a new feature
Issues Resolved
Meta issue - opensearch-project/OpenSearch#3959
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.