Proxy authentication tests #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2211 +/- ##
============================================
- Coverage 61.16% 61.04% -0.12%
+ Complexity 3274 3268 -6
============================================
Files 259 259
Lines 18337 18337
Branches 3248 3248
============================================
- Hits 11215 11193 -22
- Misses 5535 5558 +23
+ Partials 1587 1586 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lukasz-soszynski-eliatra
force-pushed
the
proxy-authentication-tests
branch
from
81f509f to
9b4748b
Compare
DarshitChanpura
requested changes
Nov 2, 2022
There was a problem hiding this comment.
Ty @lukasz-soszynski-eliatra ! One request, could you please add a brief javadoc for all the new classes that you have added in this PR. Would be super helpful down the line.
lukasz-soszynski-eliatra
force-pushed
the
proxy-authentication-tests
branch
from
b15937f to
1510172
Compare
|
Done |
lukasz-soszynski-eliatra
force-pushed
the
proxy-authentication-tests
branch
from
1510172 to
dffb6bc
Compare
DarshitChanpura
previously approved these changes
Nov 8, 2022
|
Bwc tests are broken on main. Tracking issue here: #2221 |
lukasz-soszynski-eliatra
force-pushed
the
proxy-authentication-tests
branch
from
dffb6bc to
4abb296
Compare
peternied
previously approved these changes
Nov 10, 2022
lukasz-soszynski-eliatra
force-pushed
the
proxy-authentication-tests
branch
from
4abb296 to
6f42908
Compare
8 tasks
lukasz-soszynski-eliatra
force-pushed
the
proxy-authentication-tests
branch
2 times, most recently
from
c703679 to
5a00e3b
Compare
cwperks
previously approved these changes
Nov 23, 2022
|
@lukasz-soszynski-eliatra Looks like there are some merge conflicts. Can you please resolve them? |
Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com>
lukasz-soszynski-eliatra
force-pushed
the
proxy-authentication-tests
branch
from
5a00e3b to
d9c82f7
Compare
|
Done, conflicts resolved :) |
cwperks
approved these changes
Nov 29, 2022
peternied
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lukasz Soszynski lukasz.soszynski@eliatra.com
Description
[Describe what this change achieves]
Integration tests related to proxy authentication added
Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.