-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command-line only plugin install action #2266
Closed
stephen-crawford
wants to merge
70
commits into
opensearch-project:main
from
stephen-crawford:UniversalPluginInstall
Closed
Changes from 69 commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
949a635
Rebase
stephen-crawford e92d0cd
Undo bad file changes
stephen-crawford 30c8adb
reset accidental changes
stephen-crawford 705f9d9
Swap the version number
stephen-crawford 282a500
final changes
stephen-crawford 8e6fdc6
Fix typos
stephen-crawford 858068c
Remove linux name
stephen-crawford c477372
fix rename
stephen-crawford 710a8a2
Make sure passes without jdk 11
stephen-crawford aa59db2
Fully working once JDK 11 is fixed
stephen-crawford 15c4005
Reset to working version and add fail fast
stephen-crawford 3258eb9
Remove docker
stephen-crawford b531417
Test Without Docker
stephen-crawford a6b8113
Test Without Docker
stephen-crawford 3f8e05a
Hard coded OSs since casing breaks download
stephen-crawford 24e967d
Hard coded OSs since casing breaks download
stephen-crawford 85d7d35
Swap file paths in download to their actual path
stephen-crawford a8b9fbd
Fix bracket position
stephen-crawford 0faf6e9
try to fix the file suffixes
stephen-crawford 3d0a1fa
Remove -f from del
stephen-crawford 0f14071
LS directories
stephen-crawford cb6bf84
Fix name paths
stephen-crawford 9bf4fb2
Remove SNAPSHOT mention from Linux
stephen-crawford 2ec2a27
Fix missing bracket
stephen-crawford 8044b7f
Path changes
stephen-crawford 9d62afe
Remove doubled directory name
stephen-crawford e8ef729
Remove doubled directory name
stephen-crawford cf8a512
Check plugin install path names
stephen-crawford 1b23eb7
Change plugin file name
stephen-crawford 562d45b
Change plugin file name
stephen-crawford 5c34160
Add echos
stephen-crawford e9971bd
Edit file names for mv and del
stephen-crawford f0d8cbd
Add extra 0 to OS sec version
stephen-crawford fa6cc22
removed echos
stephen-crawford 7e29565
Fix wildcard in windows extraction and change pipe in linux run
stephen-crawford 6b45e15
Add echoes every step
stephen-crawford bc6960c
Add echoes every step
stephen-crawford 0c38049
Cd back and then installl
stephen-crawford 3e97659
Use min builds instead of distributions
stephen-crawford 99cb135
Add SNAPSHOT suffix
stephen-crawford fa406a2
add .sh
stephen-crawford b2cf121
Test linux, fixed path name
stephen-crawford bb7f5f3
Fix pipe format
stephen-crawford c1a3977
Add echo for steps
stephen-crawford 6a7dd18
Add echo for steps
stephen-crawford 2b09732
use arrows instead of bars
stephen-crawford f1aabcb
Add echo to front of install
stephen-crawford 83e81dc
Try process again
stephen-crawford 3d2c12e
Try to make sure file path is correct for plugin file install
stephen-crawford 7ff3310
Use pwd in linux install
stephen-crawford a17cc0a
Use pwd in linux install
stephen-crawford fe030ba
remove echo for pipe
stephen-crawford c8146a6
Try with quotes
stephen-crawford 2d35d95
Try printf '%s\n' y n n y y n
stephen-crawford ff5ff60
Try no pipinh
stephen-crawford b3d3f57
Bin/bash -c
stephen-crawford c330eb6
Bin/bash -c
stephen-crawford 51eac85
Add ls for os dir paths
stephen-crawford e8b18ee
Add ls for os dir paths
stephen-crawford 49a27b2
Fix permissions
stephen-crawford 0639752
Work?
stephen-crawford 62d62bd
Ls OS bin:
stephen-crawford 03fb2de
Remove suffix
stephen-crawford 771c205
Test Linux and JDK 17
stephen-crawford 639f217
specify bin/bash for run
stephen-crawford 009bcf7
Craig's suggestion
stephen-crawford 318e6c6
Test on windows and linux fully without docker
stephen-crawford cc6e627
Re enable workflows
stephen-crawford 134cc46
Merge branch 'main' into UniversalPluginInstall
stephen-crawford 10da06a
readd spaces around workflow_dispatch trigger
stephen-crawford File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change the source?
https://ci.opensearch.org/...
[1] is the freshest place to get them from according to the OpenSearch-Build team [2][1] https://github.com/opensearch-project/opensearch-build/blob/main/README.md#latest-distribution-url
[2] opensearch-project/opensearch-build#2754
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I swapped the source for two reasons: 1) We do not have the same type of catalogue for Windows as we do Linux so what was available to Linux was not for Windows which made the processes for the two more divergent then I liked 2) Related to that, the most recent distributions seemed to have security already installed which would require that I make the script uninstall and reinstall the plugin to actually test what they are meant to test. Likewise, they probably would have had other plugins installed and I am not sure how much I could account for the differences in what those install and removal processes looked like. With the minimums snapshots, there is basically a barebones framework of OpenSearch to work with which I think makes it easier to install into but also gives you a better idea of whether your particular plugin is working right.
Good question though--I actually thought a bit about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't sound right, the
opensearch-min-*
is suppose to be only the core version of OpenSearch with no plugins, could you see about making a bug on OpenSearch-Build if that is the case.