Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify reusable action to support workflow call acrossing repositories #2290

Merged

Conversation

RyanL1997
Copy link
Collaborator

@RyanL1997 RyanL1997 commented Dec 1, 2022

Signed-off-by: Ryan Liang jiallian@amazon.com

Description

Modify reusable action to support workflow call acrossing repositories

Category

Refactoring

Issues Resolved

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Merging #2290 (e326477) into main (cad7c72) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2290      +/-   ##
============================================
- Coverage     61.04%   60.98%   -0.06%     
+ Complexity     3268     3263       -5     
============================================
  Files           259      259              
  Lines         18337    18337              
  Branches       3248     3248              
============================================
- Hits          11193    11182      -11     
- Misses         5559     5565       +6     
- Partials       1585     1590       +5     
Impacted Files Coverage Δ
...ch/security/auditlog/routing/AsyncStoragePool.java 50.00% <0.00%> (-5.56%) ⬇️
...urity/ssl/transport/SecuritySSLNettyTransport.java 62.36% <0.00%> (-4.31%) ⬇️
...earch/security/ssl/util/SSLConnectionTestUtil.java 93.18% <0.00%> (-2.28%) ⬇️
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 57.46% <0.00%> (-1.50%) ⬇️
...search/security/transport/SecurityInterceptor.java 75.38% <0.00%> (-0.77%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DarshitChanpura DarshitChanpura merged commit 1a8654d into opensearch-project:main Dec 2, 2022
@DarshitChanpura DarshitChanpura added the backport 2.x backport to 2.x branch label Dec 14, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-2290-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1a8654d3491f2a619482644a135762d10d9f670d
# Push it to GitHub
git push --set-upstream origin backport/backport-2290-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2290-to-2.x.

DarshitChanpura pushed a commit to DarshitChanpura/security that referenced this pull request Jul 30, 2024
opensearch-project#2290)

Signed-off-by: Ryan Liang <jiallian@amazon.com>

Signed-off-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com>
(cherry picked from commit 1a8654d)
DarshitChanpura pushed a commit to DarshitChanpura/security that referenced this pull request Jul 31, 2024
opensearch-project#2290)

Signed-off-by: Ryan Liang <jiallian@amazon.com>

Signed-off-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com>
(cherry picked from commit 1a8654d)
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants