Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Revert "Windows Install Action Fix" #2404

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jan 13, 2023

Backport #2401 to 2.x

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks requested a review from a team January 13, 2023 17:45
@codecov-commenter
Copy link

Codecov Report

Merging #2404 (c776c8d) into 2.x (f5c6dcd) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #2404      +/-   ##
============================================
- Coverage     61.09%   61.00%   -0.10%     
+ Complexity     3254     3246       -8     
============================================
  Files           258      258              
  Lines         18130    18130              
  Branches       3231     3231              
============================================
- Hits          11077    11060      -17     
- Misses         5483     5494      +11     
- Partials       1570     1576       +6     
Impacted Files Coverage Δ
...ch/security/auditlog/routing/AsyncStoragePool.java 50.00% <0.00%> (-5.56%) ⬇️
...urity/ssl/transport/SecuritySSLNettyTransport.java 62.36% <0.00%> (-4.31%) ⬇️
...earch/security/ssl/util/SSLConnectionTestUtil.java 93.18% <0.00%> (-2.28%) ⬇️
...ecurity/configuration/ConfigurationRepository.java 72.13% <0.00%> (-2.19%) ⬇️
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 57.46% <0.00%> (-1.50%) ⬇️
...search/security/transport/SecurityInterceptor.java 75.38% <0.00%> (-0.77%) ⬇️
...a/org/opensearch/security/tools/SecurityAdmin.java 35.75% <0.00%> (-0.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@DarshitChanpura DarshitChanpura merged commit b6e4415 into opensearch-project:2.x Jan 13, 2023
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants