Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release note for 1.3.8 #2425

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Add release note for 1.3.8 #2425

merged 2 commits into from
Feb 17, 2023

Conversation

RyanL1997
Copy link
Collaborator

@RyanL1997 RyanL1997 commented Feb 1, 2023 •
edited
Loading

Signed-off-by: Ryan Liang jiallian@amazon.com

Description

Add release note for 1.3.8

  • Maintenance

Issues Resolved

Is this a backport? If so, please add backport PR # and/or commits #

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@RyanL1997 RyanL1997 requested a review from a team February 1, 2023 20:05
@RyanL1997 RyanL1997 added backport 1.x backport to 1.x branch backport 1.3 backport to 1.3 branch labels Feb 1, 2023
cwperks
cwperks previously approved these changes Feb 1, 2023
View reviewed changes
DarshitChanpura
DarshitChanpura requested changes Feb 1, 2023
View reviewed changes
Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2406 #2351 is missing from this list. They should be added.
#2422 this will be part of next release correct?

@cwperks
Copy link
Member

cwperks commented Feb 1, 2023 •
edited
Loading

@DarshitChanpura #2422 was not included in the RC so shouldn't be included here.

#2351 is included as #2349 with better naming for the release notes

#2406 is ok to leave out IMO bc it nullified a previous change. Revert "Windows Install Action Fix" wouldn't add much value in the release notes. If it were to be included there would need to be a blurb about reverting -y of install_demo_configuration to its original behavior

@DarshitChanpura
Copy link
Member

@DarshitChanpura #2422 was not included in the RC so shouldn't be included here.

#2351 is included as #2349 with better naming for the release notes

#2406 is ok to leave out IMO bc it nullified a previous change. Revert "Windows Install Action Fix" wouldn't add much value in the release notes. If it were to be included there would need to be a blurb about reverting -y of install_demo_configuration to its original behavior

sounds good

DarshitChanpura
DarshitChanpura previously approved these changes Feb 1, 2023
View reviewed changes
@RyanL1997 RyanL1997 removed the backport 1.3 backport to 1.3 branch label Feb 1, 2023
@RyanL1997
Copy link
Collaborator Author

Removing the backport 1.3 label since I have created a manual backport #2426.

@cwperks
Copy link
Member

cwperks commented Feb 9, 2023

@RyanL1997 Can you re-base this PR?

@RyanL1997
Add release note for 1.3.8
cb4be4d 
Signed-off-by: Ryan Liang <jiallian@amazon.com>
@RyanL1997
Rebase and fix lint
aafe521 
Signed-off-by: Ryan Liang <jiallian@amazon.com>
@stephen-crawford stephen-crawford merged commit 43d09d7 into opensearch-project:main Feb 17, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 17, 2023
@RyanL1997 @github-actions
Add release note for 1.3.8 (#2425)
254f4a6 
* Add release note for 1.3.8

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Rebase and fix lint

Signed-off-by: Ryan Liang <jiallian@amazon.com>

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
(cherry picked from commit 43d09d7)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 17, 2023
Merged
cwperks pushed a commit that referenced this pull request Feb 20, 2023
@opensearch-trigger-bot
Add release note for 1.3.8 (#2425) (#2447)
bfcc566 
* Add release note for 1.3.8

Signed-off-by: Ryan Liang <jiallian@amazon.com>
MaciejMierzwa pushed a commit to MaciejMierzwa/security that referenced this pull request Apr 27, 2023
@RyanL1997 @MaciejMierzwa
Add release note for 1.3.8 (opensearch-project#2425)
d8d3025 
* Add release note for 1.3.8

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Rebase and fix lint

Signed-off-by: Ryan Liang <jiallian@amazon.com>

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephen-crawford stephen-crawford stephen-crawford approved these changes

@cwperks cwperks cwperks approved these changes

@DarshitChanpura DarshitChanpura DarshitChanpura left review comments

Assignees
No one assigned
Labels
backport 1.x backport to 1.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RyanL1997 @cwperks @DarshitChanpura @stephen-crawford