Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imports from org.opensearch.common.xcontent to org.opensearch.core.xcontent #2457

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Feb 21, 2023

Description

Reacts to refactoring done on xcontent classes from core. Many imports from org.opensearch.common.xcontent were switched to org.opensearch.core.xcontent.

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Build fix

Issues Resolved

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…core.xcontent

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
@peternied
Copy link
Member

@cwperks Fixed a couple of lingering issues and pushed to your branch. I'll be monitoring

@codecov-commenter
Copy link

Codecov Report

Merging #2457 (7a2f4e1) into main (0a92299) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 7a2f4e1 differs from pull request most recent head 9649845. Consider uploading reports for the commit 9649845 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #2457      +/-   ##
============================================
- Coverage     61.23%   61.22%   -0.01%     
+ Complexity     3326     3324       -2     
============================================
  Files           260      260              
  Lines         18487    18487              
  Branches       3267     3267              
============================================
- Hits          11320    11319       -1     
  Misses         5574     5574              
- Partials       1593     1594       +1     
Impacted Files Coverage Δ
...ic/auth/http/kerberos/HTTPSpnegoAuthenticator.java 0.00% <ø> (ø)
.../opensearch/security/OpenSearchSecurityPlugin.java 79.87% <ø> (ø)
.../action/configupdate/ConfigUpdateNodeResponse.java 77.27% <ø> (ø)
...rity/action/configupdate/ConfigUpdateResponse.java 64.28% <ø> (ø)
...nsearch/security/action/whoami/WhoAmIResponse.java 0.00% <ø> (ø)
...earch/security/auditlog/impl/AbstractAuditLog.java 73.75% <ø> (ø)
...search/security/auditlog/impl/RequestResolver.java 67.61% <ø> (ø)
...ty/configuration/ConfigurationLoaderSecurity7.java 70.43% <ø> (ø)
...security/configuration/DlsFlsFilterLeafReader.java 62.31% <ø> (ø)
...rch/security/configuration/DlsFlsRequestValve.java 0.00% <ø> (ø)
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternied peternied merged commit 2ce736a into opensearch-project:main Feb 22, 2023
@peternied
Copy link
Member

I've created #2467 to disable mac CI builds which impacted this pull request

MaciejMierzwa pushed a commit to MaciejMierzwa/security that referenced this pull request Apr 27, 2023
…core.xcontent (opensearch-project#2457)

* Update imports from org.opensearch.common.xcontent to org.opensearch.core.xcontent

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Co-authored-by: Peter Nied <petern@amazon.com>
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Build Break] XContent refactor
4 participants