Remove dependency on javax.annotation implementation as OpenSearch now has one. #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w has one. This resolves "JAR hell" issues when installing the plugin. Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Xtansia
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford and
reta
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2801 +/- ##
=========================================
Coverage 61.47% 61.48%
+ Complexity 3403 3401 -2
=========================================
Files 266 266
Lines 18865 18865
Branches 3302 3302
=========================================
+ Hits 11598 11599 +1
+ Misses 5673 5669 -4
- Partials 1594 1597 +3 |
reta
approved these changes
May 30, 2023
reta
reviewed
May 30, 2023
| @@ -346,7 +346,6 @@ task integrationTest(type: Test) { | |||
| check.dependsOn integrationTest | |||
|
|
|||
| dependencies { | |||
| implementation 'jakarta.annotation:jakarta.annotation-api:1.3.5' | |||
There was a problem hiding this comment.
That's is right, it comes from the recent protobuf-related changes when the @Generated annotation was introduced, thanks @Xtansia
cwperks
added
backport 2.x
RyanL1997
pushed a commit
to RyanL1997/security
that referenced
this pull request
Jun 9, 2023
…w has one. (opensearch-project#2801) This resolves "JAR hell" issues when installing the plugin. Signed-off-by: Thomas Farr <tsfarr@amazon.com>
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Jun 13, 2023
…w has one. (opensearch-project#2801) This resolves "JAR hell" issues when installing the plugin. Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Jun 13, 2023
…w has one. (opensearch-project#2801) This resolves "JAR hell" issues when installing the plugin. Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
RyanL1997
pushed a commit
to RyanL1997/security
that referenced
this pull request
Jun 13, 2023
…w has one. (opensearch-project#2801) This resolves "JAR hell" issues when installing the plugin. Signed-off-by: Thomas Farr <tsfarr@amazon.com>
This was referenced Jun 13, 2023
samuelcostae
pushed a commit
to samuelcostae/security
that referenced
this pull request
Jun 19, 2023
…w has one. (opensearch-project#2801) This resolves "JAR hell" issues when installing the plugin. Signed-off-by: Thomas Farr <tsfarr@amazon.com>
samuelcostae
pushed a commit
to samuelcostae/security
that referenced
this pull request
Jun 19, 2023
…w has one. (opensearch-project#2801) This resolves "JAR hell" issues when installing the plugin. Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Sam <samuel.costa@eliatra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the dependency on
jakarta.annotationan implementation ofjavax.annotation, as OpenSearch now itself takes a dependency on an implementation ofjavax.annotation.javax.annotationcausing a JAR hell error when installing the plugin.Also requires backporting to 2.x
Issues Resolved
Resolves #2799
Testing
Manual testing of repro steps in #2799 but using local build of plugin rather than published snapshot.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.