SecurityRestFilter, authorizeRequest() audit log tests #3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
MaciejMierzwa
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
Codecov Report
@@ Coverage Diff @@
## main #3084 +/- ##
============================================
- Coverage 62.45% 62.39% -0.07%
+ Complexity 3353 3348 -5
============================================
Files 254 254
Lines 19741 19741
Branches 3334 3334
============================================
- Hits 12329 12317 -12
- Misses 5783 5790 +7
- Partials 1629 1634 +5 |
|
Thanks for creating this PR @MaciejMierzwa it looks like there is another issue [1] around audit log scenarios, can you see about completing both with this PR? If not would you want to pick up that other issue as a fast follow up? |
peternied
changed the title
peternied
approved these changes
Aug 4, 2023
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testWhoAmIPost() throws Exception { | ||
| public void testWhoAmIPost() { |
DarshitChanpura
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding tests for #2700, relevant PR: DarshitChanpura#5. The goal is to test audit logs hit in authorizeRequest() method from SecurityRestFilterExtension class.
Issues Resolved:
#2700
Testing
Integration testing added
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.