Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adds automation script to add issue label #3331

Conversation

DarshitChanpura
Copy link
Member

@DarshitChanpura DarshitChanpura commented Sep 7, 2023

Adds an automation workflow to port over labels from issues to PRs

Resolves #3335

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there might already be a GitHub Action that offers this functionality or more, see [labels] in the marketplace.

Found a couple that might handle this scenario

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #3331 (6ad1acc) into main (72c6186) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 6ad1acc differs from pull request most recent head 82308bb. Consider uploading reports for the commit 82308bb to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3331      +/-   ##
============================================
- Coverage     64.17%   64.15%   -0.03%     
+ Complexity     3472     3470       -2     
============================================
  Files           263      263              
  Lines         20112    20112              
  Branches       3359     3359              
============================================
- Hits          12907    12902       -5     
- Misses         5526     5532       +6     
+ Partials       1679     1678       -1     

see 1 file with indirect coverage changes

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
@DarshitChanpura
Copy link
Member Author

hmm. i tried using an existing workflow. It seems to be working for same repo: DarshitChanpura#8

but no across forks 🤔

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
@peternied
Copy link
Member

@DarshitChanpura but no across forks 🤔 I'm pretty sure that's by the design of the GitHub security model, I wouldn't want forks to be able to modify my repro.

During our triage session today, the associated issue was rejected. It looks like this feature might be useful in the OpenSearch repo maybe you'd consider shifting your change to that repository.

@peternied peternied closed this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Port issue labels to PR
2 participants