[Refactor] Change HTTP routes for Audit and Config PUT methods #3359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrey Pleskach <ples@aiven.io>
willyborankin
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford and
reta
as code owners
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #3359 +/- ##
=========================================
Coverage 64.17% 64.18%
- Complexity 3472 3473 +1
=========================================
Files 263 263
Lines 20112 20107 -5
Branches 3359 3357 -2
=========================================
- Hits 12907 12905 -2
- Misses 5526 5528 +2
+ Partials 1679 1674 -5
|
cwperks
approved these changes
Sep 18, 2023
DarshitChanpura
changed the title
src/test/java/org/opensearch/security/dlic/rest/api/AuditApiActionValidationTest.java
Show resolved
Hide resolved
src/test/java/org/opensearch/security/dlic/rest/api/SecurityConfigApiActionValidationTest.java
Show resolved
Hide resolved
peternied
approved these changes
Sep 22, 2023
|
@DarshitChanpura Can you mark the conversations as resolved if they have been addressed? This PR cannot be merged until all comments are marked as resolved. |
|
I've marked those outstanding comment threads as resolved - as they all look resolved too me |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
Change routs for audit and security configuration PUT methods.
The previous configuration used the `{name}` parameter which is
confusing since `config` the only allowed value for this parameter. This
PR changes routes' configuration and removes useless validation for
them.
Signed-off-by: Andrey Pleskach <ples@aiven.io>
(cherry picked from commit 22f00fa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change routs for audit and security configuration PUT methods.
The previous configuration used the
{name}parameter which is confusing sinceconfigthe only allowed value for this parameter. This PR changes routes' configuration and removes useless validation for them.Note: We do not need to change documentation for endpoints and keep backward compatibility. e.g. Audit endpoint https://opensearch.org/docs/latest/security/access-control/api/#audit-logs
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.