Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Allow for automatic merging of dependabot changes after checks pass #3409

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ab891d0 from #3408.

…3408)

### Description
Allow for automatic merging of dependabot changes after checks pass

### Issues Resolved
- Related opensearch-project/OpenSearch#10211

### Check List
- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Peter Nied <peternied@hotmail.com>
(cherry picked from commit ab891d0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #3409 (d9a1f78) into 2.x (3841f14) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #3409      +/-   ##
============================================
+ Coverage     64.09%   64.13%   +0.04%     
- Complexity     3369     3370       +1     
============================================
  Files           256      256              
  Lines         19515    19515              
  Branches       3297     3297              
============================================
+ Hits          12508    12516       +8     
+ Misses         5365     5356       -9     
- Partials       1642     1643       +1     

see 2 files with indirect coverage changes

@peternied
Copy link
Member

@reta I had a though about allowing backports to be automatically merged such as this one, hah!

Then it occurred to me that while the 'bot' is doing the backporting and could be allowed, a non-maintainer human could add the label and cause a change to be merged somewhere that wasn't intended or appropriately timed. Maybe someday... but not yet :D

@reta reta self-requested a review September 26, 2023 13:28
@stephen-crawford
Copy link
Contributor

Retrying windows runners.

@github-actions
Copy link
Contributor

This pull request could have been automatically merged by adding the author 'opensearch-trigger-bot[bot]' to discerning-merger list of allowed-authors.

@DarshitChanpura DarshitChanpura merged commit 36bd1b0 into 2.x Oct 2, 2023
99 of 101 checks passed
@DarshitChanpura DarshitChanpura deleted the backport/backport-3408-to-2.x branch October 2, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants