-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracer to Transport #3463
Add tracer to Transport #3463
Conversation
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #3463 +/- ##
============================================
+ Coverage 64.57% 64.60% +0.02%
- Complexity 3548 3551 +3
============================================
Files 269 269
Lines 20365 20365
Branches 3377 3377
============================================
+ Hits 13151 13156 +5
+ Misses 5526 5522 -4
+ Partials 1688 1687 -1
|
@peternied @davidlago @DarshitChanpura Please take a look. Windows backward compatibility is failing, I am not able to find the reason. Please guide me here. |
CC: @reta |
@Gaganjuneja The windows failures were coming from this IllegalStateException. Is there a race condition during the start-up process, windows is much 'slower' that the ubuntu builds. Can you look into this?
|
Created an issue for this - #3464 |
@peternied I was trying to reproduce the issue on Windows box locally, sadly no luck, BUT it looks to me this is the issue with distribution: the OS 3.0.0-SNAPSHOT was not yet updated (so no changes in transport) but security plugin tried to use the modified signature - the instantiation fails (which will explain the error) |
### Description Add tracer to fix the breaking issue. ### Issues Resolved - #3462 ### Check List - [ ] New functionality includes testing - [ ] New functionality has been documented - [x] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> (cherry picked from commit bfba97a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
### Description Add tracer to fix the breaking issue. ### Issues Resolved - #3462 ### Check List - [ ] New functionality includes testing - [ ] New functionality has been documented - [x] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> (cherry picked from commit bfba97a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Add tracer to fix the breaking issue.
Issues Resolved
Add instrumentation in InboundHandler #10143
#3462Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.