[2.x] Extracts demo configuration setup into a java tool, adds support for Bundled JDK for this tool and updates DEVELOPER_GUIDE.md #3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#3669) This change extracts the core demo configuration install script to java tool to allow re-usability while leveraging that OpenSearch itself is JAVA process. All other tools shipped by security are java tools, and now with this PR, demo configuration setup will also be a java tool. --------- Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
…ml (opensearch-project#3734) Adds 4 config lines that were missed in the original PR: https://github.com/opensearch-project/security/blob/deff84265cd22badf9cca02a3240aeb000acb439/tools/install_demo_configuration.sh#L384C1-L388C1 --------- Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
### Description This PR adds tests associated with the demo-configuration tool. ## Issues Resolved: - Resolves opensearch-project#3636 ### Testing - Unit Testing - Integration Testing ### Check List - [x] New functionality includes testing ~- [ ] New functionality has been documented~ - [x] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
…be compliant with opensearch naming convention (opensearch-project#3843) ### Issues Resolved - Resolves opensearch-project#3842 ### Testing - automated tests ### Check List - [x] New functionality includes testing ~- [ ] New functionality has been documented~ - [x] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.x #3845 +/- ##
============================================
+ Coverage 64.88% 65.00% +0.11%
- Complexity 3661 3729 +68
============================================
Files 292 297 +5
Lines 20648 21000 +352
Branches 3402 3440 +38
============================================
+ Hits 13398 13651 +253
- Misses 5567 5641 +74
- Partials 1683 1708 +25
|
|
Plugin install failures due to mismatch in github workflows between main and 2.x. This is the source PR that was not backported. https://github.com/opensearch-project/security/pull/2290/files I'll refactor current PR to match the plugin install workflow on 2.x |
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
…d prevents password from being printed in the logs (opensearch-project#3850) Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
…3844) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com>
DarshitChanpura
requested review from
cliu123,
cwperks,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
|
There was mismatch in documentation in DEVELOPER_GUIDE.md between main and 2x. I've refactored that file to be in line with main. |
DarshitChanpura
changed the title
RyanL1997
approved these changes
Dec 18, 2023
derek-ho
added a commit
to derek-ho/security
that referenced
this pull request
Dec 19, 2023
…s support for Bundled JDK for this tool and updates DEVELOPER_GUIDE.md (opensearch-project#3845)" This reverts commit ea9546e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backports following commits related to demo configuration tool from main to 2.x:
Issues Resolved
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.